All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: "Goucem, Fabrice" <f-goucem@ti.com>
Cc: hari n <hari.zoom@gmail.com>,
	"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH] Add support for packet synchronised sDMA transfers.
Date: Tue, 11 May 2010 15:47:32 -0700	[thread overview]
Message-ID: <20100511224731.GJ13931@atomide.com> (raw)
In-Reply-To: <74583B8642AB8841B30447520659FCA9EB8A7F8D@dnce01.ent.ti.com>

* Goucem, Fabrice <f-goucem@ti.com> [100309 05:11]:
> Hi Hari,
> 
> Thanks for your comment.
> What you're saying is perfectly true, however I find current way is a bit awkward and potentially dangerous if for any reason value of OMAP_DMA_SYNC_PACKET changes in the future, or if more constants are defined later on.
> 
> I think proposed patch improves the readability of the code and makes it clearer to developers what DMA synchronisations are supported.

In that case the patch subject is wrong, these features are
already supported as Hari pointed out. Maybe update the
patch subject and description accordingly?

Tony

      reply	other threads:[~2010-05-11 22:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-03 10:20 [PATCH] Add support for packet synchronised sDMA transfers Fabrice Goucem
2010-03-03 13:02 ` hari n
2010-03-09 13:14   ` Goucem, Fabrice
2010-05-11 22:47     ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100511224731.GJ13931@atomide.com \
    --to=tony@atomide.com \
    --cc=f-goucem@ti.com \
    --cc=hari.zoom@gmail.com \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.