From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753755Ab0ELAI3 (ORCPT ); Tue, 11 May 2010 20:08:29 -0400 Received: from e7.ny.us.ibm.com ([32.97.182.137]:55775 "EHLO e7.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753308Ab0ELAI2 (ORCPT ); Tue, 11 May 2010 20:08:28 -0400 Date: Tue, 11 May 2010 17:08:21 -0700 From: "Paul E. McKenney" To: Greg KH Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, laijs@cn.fujitsu.com, dipankar@in.ibm.com, akpm@linux-foundation.org, mathieu.desnoyers@polymtl.ca, josh@joshtriplett.org, dvhltc@us.ibm.com, niv@us.ibm.com, tglx@linutronix.de, peterz@infradead.org, rostedt@goodmis.org, Valdis.Kletnieks@vt.edu, dhowells@redhat.com, eric.dumazet@gmail.com, Mathieu Desnoyers Subject: Re: [PATCH RFC tip/core/rcu 06/11] staging: remove all rcu head initializations Message-ID: <20100512000821.GH2336@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <20100511233241.GA20250@linux.vnet.ibm.com> <1273620786-20392-6-git-send-email-paulmck@linux.vnet.ibm.com> <20100511234523.GA1450@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100511234523.GA1450@suse.de> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 11, 2010 at 04:45:23PM -0700, Greg KH wrote: > On Tue, May 11, 2010 at 04:33:01PM -0700, Paul E. McKenney wrote: > > Remove all rcu head inits. We don't care about the RCU head state before passing > > it to call_rcu() anyway. Only leave the "on_stack" variants so debugobjects can > > keep track of objects on stack. > > > > Signed-off-by: Mathieu Desnoyers > > Signed-off-by: Paul E. McKenney > > Cc: Greg Kroah-Hartman > > --- > > drivers/staging/batman-adv/hard-interface.c | 1 - > > Is this safe to apply to my tree now? Or do you want to take it through > your tree as it depends on other stuff? Because the rcu_head in this case is not in an auto (on-stack) variable, this commit is safe to apply to your tree now. Let me know when you have applied it, and I will happily remove it from mine. ;-) Thanx, Paul > If your tree, no objection from me, feel free to add: > Acked-by: Greg Kroah-Hartman > > thanks, > > greg k-h