From: Neil Brown <neilb@suse.de>
To: Dan Williams <dan.j.williams@intel.com>
Cc: linux-raid@vger.kernel.org
Subject: Re: [RFC PATCH 0/2] a couple of readonly handling fixups
Date: Wed, 12 May 2010 08:33:32 +1000 [thread overview]
Message-ID: <20100512083332.45e71edf@notabene.brown> (raw)
In-Reply-To: <AANLkTilViY9QWurh9QN07zShPt9rPlfCOVVtH7896yoz@mail.gmail.com>
On Tue, 11 May 2010 11:06:48 -0700
Dan Williams <dan.j.williams@intel.com> wrote:
> On Sun, Jan 18, 2009 at 4:07 PM, Neil Brown <neilb@suse.de> wrote:
> > On Thursday January 8, dan.j.williams@intel.com wrote:
> >> The BUG_ON(mddev->ro == 1) in md_write_start can be triggered under two
> >> circumstances in recent kernels. One was reported by Justin Maggard:
> >
> > Hi Dan,
> > Thanks for following up with this.....
> >
> > (I meant to send this over a week ago, but I've been on vaction
> > in Tasmania and my mobile has no coverage....)
> >
> [..]
> >> md: set mddev readonly flag on blkdev BLKROSET ioctl
> >
> > This one I'm happy with. I'll make sure it gets through.
>
> This slippery bugger seems to have evaded upstream, do you want me to resend?
No thanks, the link below is good enough.
That patch is now in my for-next branch and will go for-linus in
2.6.whatevercomesnext.
I normally stick that sort of thing somewhere in my stack before replying
that "I will make it so". I guess I failed that time.
>
> Here is a link for reference:
> http://marc.info/?l=linux-raid&m=123139948817348&w=2
>
> I have seen another report of the md_write_start() BUG_ON triggering
> so I'm wondering if there are other ways for mddev->ro and
> bdev->bd_part->policy to get out of sync, or if they are just hitting
> the bug that this patch fixes?
Maybe we should just get rid of the BUG_ON??
Let's set how it goes once this patch is really in.
Thanks,
NeilBrown
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2010-05-11 22:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-08 7:24 [RFC PATCH 0/2] a couple of readonly handling fixups Dan Williams
2009-01-08 7:24 ` [PATCH 1/2] md: set mddev readonly flag on blkdev BLKROSET ioctl Dan Williams
2009-01-08 7:24 ` [PATCH 2/2] Revert "Restore force switch of md array to readonly at reboot time." Dan Williams
2009-01-18 23:07 ` [RFC PATCH 0/2] a couple of readonly handling fixups Neil Brown
2010-05-11 18:06 ` Dan Williams
2010-05-11 22:33 ` Neil Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100512083332.45e71edf@notabene.brown \
--to=neilb@suse.de \
--cc=dan.j.williams@intel.com \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.