From: Randy Dunlap <randy.dunlap@oracle.com>
To: akpm@linux-foundation.org,
Michael Hennerich <michael.hennerich@analog.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH -mmotm] backlight: fix adp8860_bl build errors
Date: Wed, 12 May 2010 13:39:19 -0700 [thread overview]
Message-ID: <20100512133919.016d6286.randy.dunlap@oracle.com> (raw)
In-Reply-To: <201005120149.o4C1n7P4002637@imap1.linux-foundation.org>
From: Randy Dunlap <randy.dunlap@oracle.com>
Add slab.h to fix part of build.
Add a parameter in backlight_device_register() call to fix part of build.
drivers/video/backlight/adp8860_bl.c:215: error: implicit declaration of function 'kzalloc'
drivers/video/backlight/adp8860_bl.c:215: warning: assignment makes pointer from integer without a cast
drivers/video/backlight/adp8860_bl.c:285: error: implicit declaration of function 'kfree'
drivers/video/backlight/adp8860_bl.c:673: warning: assignment makes pointer from integer without a cast
drivers/video/backlight/adp8860_bl.c:689: error: too few arguments to function 'backlight_device_register'
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Cc: Michael Hennerich <michael.hennerich@analog.com>
---
drivers/video/backlight/adp8860_bl.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
--- mmotm-2010-0511-1820.orig/drivers/video/backlight/adp8860_bl.c
+++ mmotm-2010-0511-1820/drivers/video/backlight/adp8860_bl.c
@@ -16,6 +16,7 @@
#include <linux/fb.h>
#include <linux/backlight.h>
#include <linux/leds.h>
+#include <linux/slab.h>
#include <linux/workqueue.h>
#include <linux/i2c/adp8860.h>
@@ -647,6 +648,7 @@ static int __devinit adp8860_probe(struc
struct adp8860_bl *data;
struct adp8860_backlight_platform_data *pdata =
client->dev.platform_data;
+ struct backlight_properties props;
uint8_t reg_val;
int ret;
@@ -683,10 +685,13 @@ static int __devinit adp8860_probe(struc
data->current_brightness = 0;
i2c_set_clientdata(client, data);
+ memset(&props, 0, sizeof(props));
+ props.max_brightness = ADP8860_MAX_BRIGHTNESS;
+
mutex_init(&data->lock);
bl = backlight_device_register(dev_driver_string(&client->dev),
- &client->dev, data, &adp8860_bl_ops);
+ &client->dev, data, &adp8860_bl_ops, &props);
if (IS_ERR(bl)) {
dev_err(&client->dev, "failed to register backlight\n");
ret = PTR_ERR(bl);
next prev parent reply other threads:[~2010-05-12 20:40 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-12 1:21 mmotm 2010-05-11-18-20 uploaded akpm
2010-05-12 16:50 ` mmotm 2010-05-11-18-20 uploaded (aio build) Randy Dunlap
2010-05-12 17:07 ` Jeff Moyer
2010-05-12 17:09 ` Randy Dunlap
2010-05-12 19:42 ` mmotm 2010-05-11-18-20 uploaded (aio build; add numa) Randy Dunlap
2010-05-12 19:52 ` mmotm 2010-05-11 - dies in pm_qos_update_request() Valdis.Kletnieks
2010-05-12 21:07 ` Rafael J. Wysocki
2010-05-12 21:07 ` Rafael J. Wysocki
2010-05-12 22:12 ` Valdis.Kletnieks
2010-05-12 22:33 ` Rafael J. Wysocki
2010-05-13 14:34 ` Valdis.Kletnieks
2010-05-13 22:24 ` Rafael J. Wysocki
2010-05-13 22:24 ` Rafael J. Wysocki
2010-05-14 23:43 ` mark gross
2010-05-13 22:32 ` Rafael J. Wysocki
2010-05-13 22:32 ` Rafael J. Wysocki
2010-05-12 20:39 ` [PATCH -mmotm] misc: fix ad525X_dpot build Randy Dunlap
2010-05-12 20:53 ` Hennerich, Michael
2010-05-12 20:39 ` Randy Dunlap [this message]
2010-05-12 20:54 ` [PATCH -mmotm] backlight: fix adp8860_bl build errors Hennerich, Michael
2010-05-13 15:06 ` mmotm 2010-05-11-18-20 uploaded Valdis.Kletnieks
2010-05-13 16:02 ` Dmitry Torokhov
2010-05-13 16:20 ` Mauro Carvalho Chehab
2010-05-13 16:29 ` Valdis.Kletnieks
2010-05-13 17:32 ` Mauro Carvalho Chehab
2010-05-19 23:34 ` Mauro Carvalho Chehab
2010-05-20 4:57 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100512133919.016d6286.randy.dunlap@oracle.com \
--to=randy.dunlap@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.