From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=55954 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OCFuZ-00007N-H0
	for qemu-devel@nongnu.org; Wed, 12 May 2010 13:40:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <aurelien@aurel32.net>) id 1OCFk1-0004SJ-A5
	for qemu-devel@nongnu.org; Wed, 12 May 2010 13:29:07 -0400
Received: from hall.aurel32.net ([88.191.82.174]:59950)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <aurelien@aurel32.net>) id 1OCFk1-0004R1-5Q
	for qemu-devel@nongnu.org; Wed, 12 May 2010 13:29:05 -0400
Date: Wed, 12 May 2010 19:28:52 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] [S390] Remove warning in tcg stub
	(tcg_out_reloc)
Message-ID: <20100512172852.GC4405@hall.aurel32.net>
References: <1273595012-19587-1-git-send-email-agraf@suse.de>
	<4BE98A13.1040103@mail.berlios.de> <4BE99362.3070706@twiddle.net>
	<C08F7762-CD41-47A3-A909-ED3A9F49A3FA@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <C08F7762-CD41-47A3-A909-ED3A9F49A3FA@suse.de>
Sender: Aurelien Jarno <aurelien@aurel32.net>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, Richard Henderson <rth@twiddle.net>

On Tue, May 11, 2010 at 09:50:34PM +0200, Alexander Graf wrote:
>
> Am 11.05.2010 um 19:26 schrieb Richard Henderson <rth@twiddle.net>:
>
>> On 05/11/2010 09:47 AM, Stefan Weil wrote:
>>> Won't you get another warning about unreachable code
>>> because tcg_abort never returns?
>>
>> We don't enable that warning.
>>
>>> What about condition compilation for tcg_out_reloc
>>> (don't compile it for hosts which don't need it)?
>>
>> All hosts should need it.  S390 doesn't only because
>> it's all stubbed out.
>>
>> Frankly, it shouldn't take much effort to get a working
>> TCG for s390x...
>
> Yeah, I have submitted a patch months ago, but Aurelien didn't get  
> around to review it yet :(.
>

This is indeed the best solution. It's still on my TODO list, just that
I have limited time and it's always easier to choose to ignore one big
patch and got complains from a single person, than ignoring a lot of
small patches and getting a lot of complains...

If only people were reviewing other people patches a bit more...

-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net