From: Marcelo Tosatti <mtosatti@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Avi Kivity <avi@redhat.com>, kvm <kvm@vger.kernel.org>,
Gleb Natapov <gleb@redhat.com>
Subject: Re: [PATCH] KVM: VMX: blocked-by-sti must not defer NMI injections
Date: Wed, 12 May 2010 17:05:11 -0300 [thread overview]
Message-ID: <20100512200511.GE3308@amt.cnet> (raw)
In-Reply-To: <4BE958BE.9020503@siemens.com>
On Tue, May 11, 2010 at 03:16:46PM +0200, Jan Kiszka wrote:
> As the processor may not consider GUEST_INTR_STATE_STI as a reason for
> blocking NMI, it could return immediately with EXIT_REASON_NMI_WINDOW
> when we asked for it. But as we consider this state as NMI-blocking, we
> can run into an endless loop.
>
> Resolve this by allowing NMI injection if just GUEST_INTR_STATE_STI is
> active (originally suggested by Gleb). Intel confirmed that this is
> safe, the processor will never complain about NMI injection in this
> state.
>
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> KVM-Stable-Tag
> ---
> arch/x86/kvm/vmx.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
Applied, thanks.
prev parent reply other threads:[~2010-05-12 20:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-11 13:16 [PATCH] KVM: VMX: blocked-by-sti must not defer NMI injections Jan Kiszka
2010-05-11 13:46 ` Gleb Natapov
2010-05-12 20:05 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100512200511.GE3308@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=gleb@redhat.com \
--cc=jan.kiszka@siemens.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.