From: Greg KH <greg@kroah.com>
To: Michal Nazarewicz <m.nazarewicz@samsung.com>
Cc: linux-usb@vger.kernel.org,
Kyungmin Park <kyungmin.park@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
Viral Mehta <Viral.Mehta@lntinfotech.com>,
linux-kernel@vger.kernel.org,
Michal Nazarewicz <mina86@mina86.com>
Subject: Re: [PATCH] USB: gadget: f_mass_storage: fix in error recovery
Date: Wed, 12 May 2010 14:39:38 -0700 [thread overview]
Message-ID: <20100512213938.GA27648@kroah.com> (raw)
In-Reply-To: <1148fb1fcb3a9864a2a12fbbf2e3444827c9ed4a.1273661077.git.mina86@mina86.com>
On Wed, May 12, 2010 at 12:51:13PM +0200, Michal Nazarewicz wrote:
> In to places in fsg_common_init() an unconditional call to kfree()
> on common was performed in error recovery which is not a valid
> behaviour since fsg_common structure is not always allocated by
> fsg_common_init().
>
> To fix, the calls has been replaced with a goto to a proper error
> recovery which does the correct thing.
>
> Also, refactored fsg_common_release() function.
>
> Signed-off-by: Michal Nazarewicz <mina86@mina86.com>
Does this superseed your previous patch in this thread?
thanks,
greg k-h
next prev parent reply other threads:[~2010-05-12 21:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-12 8:16 [PATCH] USB: gadget: f_mass_storage: fix in fsg_common_init() error recovery Michal Nazarewicz
2010-05-12 8:29 ` Viral Mehta
2010-05-12 9:02 ` Michał Nazarewicz
2010-05-12 9:28 ` Viral Mehta
2010-05-12 9:36 ` Viral Mehta
2010-05-12 9:57 ` Michał Nazarewicz
2010-05-12 10:33 ` Viral Mehta
2010-05-12 10:51 ` [PATCH] USB: gadget: f_mass_storage: fix in " Michal Nazarewicz
2010-05-12 12:03 ` Viral Mehta
2010-05-12 21:39 ` Greg KH [this message]
2010-05-12 22:16 ` Michal Nazarewicz
2010-05-12 9:53 ` [PATCH] USB: gadget: f_mass_storage: fix in fsg_common_init() " Michał Nazarewicz
2010-05-12 10:06 ` Viral Mehta
2010-05-12 10:34 ` Michał Nazarewicz
2010-05-12 10:37 ` Viral Mehta
2010-05-12 10:52 ` Michał Nazarewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100512213938.GA27648@kroah.com \
--to=greg@kroah.com \
--cc=Viral.Mehta@lntinfotech.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.nazarewicz@samsung.com \
--cc=m.szyprowski@samsung.com \
--cc=mina86@mina86.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.