All of lore.kernel.org
 help / color / mirror / Atom feed
From: akpm@linux-foundation.org
To: mm-commits@vger.kernel.org
Cc: miguel.ojeda.sandonis@gmail.com, davem@davemloft.net,
	greg@kroah.com, kristoffer@gaisler.com
Subject: + serial-apbuartc-fix-two-problems-related-to-grlib_apbuart_configure-update.patch added to -mm tree
Date: Wed, 12 May 2010 15:30:47 -0700	[thread overview]
Message-ID: <201005122230.o4CMUlpi024591@imap1.linux-foundation.org> (raw)


The patch titled
     serial-apbuartc-fix-two-problems-related-to-grlib_apbuart_configure-update.
has been added to the -mm tree.  Its filename is
     serial-apbuartc-fix-two-problems-related-to-grlib_apbuart_configure-update.patch

Before you just go and hit "reply", please:
   a) Consider who else should be cc'ed
   b) Prefer to cc a suitable mailing list as well
   c) Ideally: find the original patch on the mailing list and do a
      reply-to-all to that, adding suitable additional cc's

*** Remember to use Documentation/SubmitChecklist when testing your code ***

See http://userweb.kernel.org/~akpm/stuff/added-to-mm.txt to find
out what to do about this

The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/

------------------------------------------------------
Subject: serial-apbuartc-fix-two-problems-related-to-grlib_apbuart_configure-update.
From: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>

Changes:
1. Added the grlib_apbuart_port_nr = 0 line.
2. Returned -ENODEV instead of 0 in the "no ports found branch" in
init(), because if compiled as a module, exit() will try to unregister
things that were not registered. In addition, this will alert the users
that modprobe'd.
3. Deleted the unused __FILE__ argument of the previous patch (oops
sorry :).

Signed-off-by: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Kristoffer Glembo <kristoffer@gaisler.com>
Cc: Greg KH <greg@kroah.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---

 drivers/serial/apbuart.c |    9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff -puN drivers/serial/apbuart.c~serial-apbuartc-fix-two-problems-related-to-grlib_apbuart_configure-update drivers/serial/apbuart.c
--- a/drivers/serial/apbuart.c~serial-apbuartc-fix-two-problems-related-to-grlib_apbuart_configure-update
+++ a/drivers/serial/apbuart.c
@@ -615,8 +615,10 @@ static void grlib_apbuart_configure(void
 	rp = of_find_node_by_path("/");
 	rp = of_get_next_child(rp, NULL);
 	prop = of_get_property(rp, "clock-frequency", NULL);
-	if (prop == NULL)
+	if (prop == NULL) {
+		grlib_apbuart_port_nr = 0;
 		return;
+	}
 	freq_khz = *prop;
 
 	line = 0;
@@ -672,9 +674,8 @@ static int __init grlib_apbuart_init(voi
 	/* Find all APBUARTS in device the tree and initialize their ports */
 	grlib_apbuart_configure();
 	if (grlib_apbuart_port_nr == 0) {
-		printk(KERN_INFO "Serial: GRLIB APBUART: No ports found.\n",
-			__FILE__);
-		return 0;
+		printk(KERN_INFO "Serial: GRLIB APBUART: No ports found.\n");
+		return -ENODEV;
 	}
 
 	printk(KERN_INFO "Serial: GRLIB APBUART driver\n");
_

Patches currently in -mm which might be from miguel.ojeda.sandonis@gmail.com are

serial-apbuartc-fix-two-problems-related-to-grlib_apbuart_configure.patch
serial-apbuartc-fix-two-problems-related-to-grlib_apbuart_configure-update.patch
auxdisplay-section-cleanup-in-cfag12864bfb-driver.patch


                 reply	other threads:[~2010-05-12 22:31 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201005122230.o4CMUlpi024591@imap1.linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=greg@kroah.com \
    --cc=kristoffer@gaisler.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miguel.ojeda.sandonis@gmail.com \
    --cc=mm-commits@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.