diff for duplicates of <20100513020236.GS6684@trinity.fluff.org> diff --git a/a/1.txt b/N1/1.txt index 8eca887..ded853e 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -4,11 +4,11 @@ On Thu, May 13, 2010 at 10:49:29AM +0900, Jassi Brar wrote: > > --- a/arch/arm/mach-s5p6440/clock.c > > +++ b/arch/arm/mach-s5p6440/clock.c > > @@ -357,121 +357,121 @@ static struct clk init_clocks_disable[] = { -> > .id = -1, -> > .parent = &clk_hclk.clk, -> > .enable = s5p6440_mem_ctrl, -> > - .ctrlbit = S5P_CLKCON_MEM0_HCLK_NFCON, -> > + .ctrlbit = (1 << 2), +> > ? ? ? ? ? ? ? ?.id ? ? ? ? ? ? = -1, +> > ? ? ? ? ? ? ? ?.parent ? ? ? ? = &clk_hclk.clk, +> > ? ? ? ? ? ? ? ?.enable ? ? ? ? = s5p6440_mem_ctrl, +> > - ? ? ? ? ? ? ? .ctrlbit ? ? ? ?= S5P_CLKCON_MEM0_HCLK_NFCON, +> > + ? ? ? ? ? ? ? .ctrlbit ? ? ? ?= (1 << 2), > Peculiar. I have never seen defines dropped in favor of magic numbers. I know it seems a little odd at first, but people seem to be clinging diff --git a/a/content_digest b/N1/content_digest index b37880a..f4992f9 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,14 +1,9 @@ "ref\01273710481-14856-1-git-send-email-kgene.kim@samsung.com\0" "ref\0AANLkTimTm_Vxvb2xvJnVxTxUaYguFgGeaWGypzA1yjwM@mail.gmail.com\0" - "From\0Ben Dooks <ben-linux@fluff.org>\0" - "Subject\0Re: [PATCH 11/11] ARM: S5P6440: Remove redundant defines\0" + "From\0ben-linux@fluff.org (Ben Dooks)\0" + "Subject\0[PATCH 11/11] ARM: S5P6440: Remove redundant defines\0" "Date\0Thu, 13 May 2010 03:02:36 +0100\0" - "To\0Jassi Brar <jassisinghbrar@gmail.com>\0" - "Cc\0Kukjin Kim <kgene.kim@samsung.com>" - Thomas Abraham <thomas.ab@samsung.com> - linux-samsung-soc@vger.kernel.org - ben-linux@fluff.org - " linux-arm-kernel@lists.infradead.org\0" + "To\0linux-arm-kernel@lists.infradead.org\0" "\00:1\0" "b\0" "On Thu, May 13, 2010 at 10:49:29AM +0900, Jassi Brar wrote:\n" @@ -17,11 +12,11 @@ "> > --- a/arch/arm/mach-s5p6440/clock.c\n" "> > +++ b/arch/arm/mach-s5p6440/clock.c\n" "> > @@ -357,121 +357,121 @@ static struct clk init_clocks_disable[] = {\n" - "> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240.id \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 = -1,\n" - "> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240.parent \302\240 \302\240 \302\240 \302\240 = &clk_hclk.clk,\n" - "> > \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240.enable \302\240 \302\240 \302\240 \302\240 = s5p6440_mem_ctrl,\n" - "> > - \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 .ctrlbit \302\240 \302\240 \302\240 \302\240= S5P_CLKCON_MEM0_HCLK_NFCON,\n" - "> > + \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 .ctrlbit \302\240 \302\240 \302\240 \302\240= (1 << 2),\n" + "> > ? ? ? ? ? ? ? ?.id ? ? ? ? ? ? = -1,\n" + "> > ? ? ? ? ? ? ? ?.parent ? ? ? ? = &clk_hclk.clk,\n" + "> > ? ? ? ? ? ? ? ?.enable ? ? ? ? = s5p6440_mem_ctrl,\n" + "> > - ? ? ? ? ? ? ? .ctrlbit ? ? ? ?= S5P_CLKCON_MEM0_HCLK_NFCON,\n" + "> > + ? ? ? ? ? ? ? .ctrlbit ? ? ? ?= (1 << 2),\n" "> Peculiar. I have never seen defines dropped in favor of magic numbers.\n" "\n" "I know it seems a little odd at first, but people seem to be clinging\n" @@ -45,4 +40,4 @@ "Q: What's a light-year?\n" A: One-third less calories than a regular year. -b032466769ef86b5b59d9382a4c4b2dae093ace5ea490d590f7284ec9cd91e96 +36bca94563fff996b3ae220b664e23c7d7dd5d6046f1702226127302540a7d0a
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.