From: Andrew Morton <akpm@linux-foundation.org>
To: Jan Kara <jack@suse.cz>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-fsdevel@vger.kernel.org, stable@kernel.org,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH] vfs: Fix O_NOFOLLOW behavior for paths with trailing slashes
Date: Thu, 13 May 2010 08:43:35 -0400 [thread overview]
Message-ID: <20100513084335.7267bcf5.akpm@linux-foundation.org> (raw)
In-Reply-To: <20100513154135.GB21251@quack.suse.cz>
On Thu, 13 May 2010 17:41:35 +0200 Jan Kara <jack@suse.cz> wrote:
> On Thu 13-05-10 08:24:59, Linus Torvalds wrote:
> >
> >
> > On Thu, 13 May 2010, Jan Kara wrote:
> > >
> > > According to specification
> > > mkdir d; ln -s d a; open("a/", O_NOFOLLOW | O_RDONLY)
> > > should return success but currently it did return ELOOP. Fix the code to ignore
> > > O_NOFOLLOW in case the provided path has trailing slashes. This is a regression
> > > caused by path lookup cleanup patch series.
> > >
> > > CC: stable@kernel.org
> >
> > Hmm? Is this correct? Isn't the bug introduced in this merge window, and
> > thus not relevant for stable?
> Ah, you're right! I've seen dates in the patches around December so I
> automatically thought the series went to 2.6.33 but checking git logs and
> the actual source code of 2.6.33 it went in later. I'm sorry for the
> confusion.
Yes, it's a bit tricky (for me, at least) to work out "which kernel version did
that patch go into" via git.
I just keep lots of kernel trees around and poke about with `patch
--dry-run'. PITA.
next prev parent reply other threads:[~2010-05-13 15:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 10:52 [PATCH] vfs: Fix O_NOFOLLOW behavior for paths with trailing slashes Jan Kara
2010-05-13 15:24 ` Linus Torvalds
2010-05-13 15:41 ` Jan Kara
2010-05-13 12:43 ` Andrew Morton [this message]
2010-05-13 15:47 ` Christoph Hellwig
2010-05-13 15:53 ` James Bottomley
2010-05-13 15:51 ` Jan Kara
2010-05-13 15:58 ` Linus Torvalds
2010-05-14 17:12 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100513084335.7267bcf5.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.