From: Michael Walle <michael@walle.cc>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: Commit 9c9bb6c89d4 breaks code execution from flash
Date: Thu, 13 May 2010 12:58:28 +0200 [thread overview]
Message-ID: <201005131258.28613.michael@walle.cc> (raw)
In-Reply-To: <4BEBAC83.6000209@web.de>
Am Thursday 13 May 2010 09:38:43 schrieb Jan Kiszka:
> > But i noticed another minor bug. The cfi02 doesn't handle 'read flash id'
> > on 16bit accesses correctly. It always returns 8 bit. I used something
> > like
> >
> > if (width == 2)
> > ret = pfl->ident[0] << 8 | pfl->ident[1]; /* rsp. ident[1]/ident[2]
> > */
> >
> > within the 0x90 reading as a quick workaround.
>
> Are you sure that this is valid? The whole cfi_table is also only
> provided byte-wise, same in cfi01.
At least the JEDEC ID read returns 16 bit values with x16 devices. Have a look
at:
http://www.spansion.com/Support/Datasheets/s29gl128_256n_sp_a2_e.pdf
Table II on page 51
micromonitor (the program i tested with) and uboot uses 16bit reads to read
the flash id. Have a look at
http://git.denx.de/cgi-bin/gitweb.cgi?p=u-boot.git;a=blob;f=drivers/mtd/cfi_flash.c;h=3267c5de36d1b12a190f93f9a3048ded598f84aa;hb=HEAD#l1535
--
wkr michael
next prev parent reply other threads:[~2010-05-13 11:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 21:38 [Qemu-devel] Commit 9c9bb6c89d4 breaks code execution from flash Michael Walle
2010-04-23 7:23 ` [Qemu-devel] " Jan Kiszka
2010-05-07 20:57 ` Michael Walle
2010-05-12 7:56 ` Jan Kiszka
2010-05-12 23:02 ` Michael Walle
2010-05-13 7:38 ` Jan Kiszka
2010-05-13 10:58 ` Michael Walle [this message]
2010-05-13 11:46 ` Jan Kiszka
2010-05-13 11:57 ` Jan Kiszka
2010-05-13 12:38 ` Jan Kiszka
2010-05-13 13:51 ` Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005131258.28613.michael@walle.cc \
--to=michael@walle.cc \
--cc=jan.kiszka@web.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.