From: mbroz@sourceware.org <mbroz@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2 ./WHATS_NEW lib/cache/lvmcache.c lib/comm ...
Date: 13 May 2010 13:04:06 -0000 [thread overview]
Message-ID: <20100513130406.11244.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: mbroz at sourceware.org 2010-05-13 13:04:06
Modified files:
. : WHATS_NEW
lib/cache : lvmcache.c
lib/commands : toolcontext.c
lib/filters : filter-persistent.c filter-persistent.h
Log message:
Currently if clvmd is running and user issues vgscan,
the device cache file is dumped both in vgscan and clvmd process.
Unfortunately, clvmd calls lvmcache_label_scan,
it properly destroys persistent filter, but during
persistent_filter_dump it merges old cache content back!
This causes that change in filters is not properly propagated
into device cache after vgscan on cluster.
(Only new devices are added.)
https://bugzilla.redhat.com/show_bug.cgi?id=591861
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/WHATS_NEW.diff?cvsroot=lvm2&r1=1.1555&r2=1.1556
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/cache/lvmcache.c.diff?cvsroot=lvm2&r1=1.85&r2=1.86
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/commands/toolcontext.c.diff?cvsroot=lvm2&r1=1.96&r2=1.97
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/filters/filter-persistent.c.diff?cvsroot=lvm2&r1=1.40&r2=1.41
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/filters/filter-persistent.h.diff?cvsroot=lvm2&r1=1.6&r2=1.7
--- LVM2/WHATS_NEW 2010/05/11 08:57:02 1.1555
+++ LVM2/WHATS_NEW 2010/05/13 13:04:03 1.1556
@@ -1,5 +1,6 @@
Version 2.02.65 -
=================================
+ Do not merge old device cache after we run full scan. (2.02.56)
Add pkgconfigdir Makefile variable for make install override.
Switch usage of Libs.private: to Requires.private: in devmapper.pc, lvm2app.pc.
Use field Requires.private: for devmapper-event.pc.
--- LVM2/lib/cache/lvmcache.c 2010/04/30 12:54:31 1.85
+++ LVM2/lib/cache/lvmcache.c 2010/05/13 13:04:05 1.86
@@ -567,7 +567,7 @@
* device cache for the benefit of short-lived processes.
*/
if (full_scan == 2 && cmd->is_long_lived && cmd->dump_filter)
- persistent_filter_dump(cmd->filter);
+ persistent_filter_dump(cmd->filter, 0);
r = 1;
--- LVM2/lib/commands/toolcontext.c 2010/05/05 22:37:52 1.96
+++ LVM2/lib/commands/toolcontext.c 2010/05/13 13:04:05 1.97
@@ -1341,7 +1341,7 @@
void destroy_toolcontext(struct cmd_context *cmd)
{
if (cmd->dump_filter)
- persistent_filter_dump(cmd->filter);
+ persistent_filter_dump(cmd->filter, 1);
archive_exit(cmd);
backup_exit(cmd);
--- LVM2/lib/filters/filter-persistent.c 2010/01/06 13:25:36 1.40
+++ LVM2/lib/filters/filter-persistent.c 2010/05/13 13:04:05 1.41
@@ -168,7 +168,7 @@
fprintf(fp, "\n\t]\n");
}
-int persistent_filter_dump(struct dev_filter *f)
+int persistent_filter_dump(struct dev_filter *f, int merge_existing)
{
struct pfilter *pf;
char *tmp_file;
@@ -220,7 +220,7 @@
/*
* If file contents changed since we loaded it, merge new contents
*/
- if (info.st_ctime != pf->ctime)
+ if (merge_existing && info.st_ctime != pf->ctime)
/* Keep cft open to avoid losing lock */
persistent_filter_load(f, &cft);
--- LVM2/lib/filters/filter-persistent.h 2007/08/20 20:55:25 1.6
+++ LVM2/lib/filters/filter-persistent.h 2010/05/13 13:04:05 1.7
@@ -23,6 +23,6 @@
int persistent_filter_wipe(struct dev_filter *f);
int persistent_filter_load(struct dev_filter *f, struct config_tree **cft_out);
-int persistent_filter_dump(struct dev_filter *f);
+int persistent_filter_dump(struct dev_filter *f, int merge_existing);
#endif
next reply other threads:[~2010-05-13 13:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 13:04 mbroz [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-10-11 9:09 LVM2 ./WHATS_NEW lib/cache/lvmcache.c lib/comm zkabelac
2010-04-01 10:34 agk
2009-11-24 16:11 mbroz
2009-11-24 16:10 mbroz
2008-04-02 21:23 agk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100513130406.11244.qmail@sourceware.org \
--to=mbroz@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.