From: Nathan Froyd <froydnj@codesourcery.com>
To: Sebastian Herbszt <herbszt@gmx.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ahci: convert enum to #define
Date: Thu, 13 May 2010 10:27:43 -0700 [thread overview]
Message-ID: <20100513172742.GC5834@codesourcery.com> (raw)
In-Reply-To: <1273771170$123@local>
On Thu, May 13, 2010 at 07:19:30PM +0200, Sebastian Herbszt wrote:
> Convert enum to #define.
This doesn't buy you anything except code churn. It actually makes
things worse at usual debug levels, too, because the debugger
understands enums, but not #define.
-Nathan
next prev parent reply other threads:[~2010-05-13 17:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 17:19 [Qemu-devel] [PATCH] ahci: convert enum to #define Sebastian Herbszt
2010-05-13 17:27 ` Nathan Froyd [this message]
2010-05-14 11:05 ` Sebastian Herbszt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100513172742.GC5834@codesourcery.com \
--to=froydnj@codesourcery.com \
--cc=herbszt@gmx.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.