From: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Daniel Lezcano <dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
Cc: Linux Containers
<containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org>
Subject: [PATCH lxc 1/2] lxc-unshare: accept multiple -s options
Date: Thu, 13 May 2010 14:34:12 -0500 [thread overview]
Message-ID: <20100513193412.GA15433@us.ibm.com> (raw)
(also remove -f from usage as it is not actually supported)
Signed-off-by: Serge E. Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
---
src/lxc/lxc_unshare.c | 28 ++++++++++++++++++++++++++--
1 files changed, 26 insertions(+), 2 deletions(-)
diff --git a/src/lxc/lxc_unshare.c b/src/lxc/lxc_unshare.c
index 10654f7..8db1cb7 100644
--- a/src/lxc/lxc_unshare.c
+++ b/src/lxc/lxc_unshare.c
@@ -48,7 +48,7 @@ void usage(char *cmd)
fprintf(stderr, "\t -s flags: Ored list of flags to unshare:\n" \
"\t MOUNT, PID, UTSNAME, IPC, USER, NETWORK\n");
fprintf(stderr, "\t -u <id> : new id to be set if -s USER is specified\n");
- fprintf(stderr, "\t if -f or -s PID is specified, <command> is mandatory)\n");
+ fprintf(stderr, "\t if -s PID is specified, <command> is mandatory)\n");
_exit(1);
}
@@ -154,6 +154,29 @@ static int do_start(void *arg)
return 1;
}
+void extend_namespaces(char **n, char *optarg)
+{
+ char *namespaces = *n;
+ int cont = 0, newlen = strlen(optarg) + 1; /* +1 for trailing \0 */
+
+ if (namespaces) {
+ cont = 1;
+ newlen += strlen(namespaces) + 1; /* +1 for '|' */
+ }
+
+ namespaces = realloc(namespaces, newlen);
+ if (!namespaces) {
+ perror("realloc");
+ exit(1);
+ }
+ if (cont)
+ sprintf(namespaces+strlen(namespaces), "|%s", optarg);
+ else
+ sprintf(namespaces, "%s", optarg);
+ namespaces[newlen-1] = '\0';
+ *n = namespaces;
+}
+
int main(int argc, char *argv[])
{
int opt, status;
@@ -174,7 +197,8 @@ int main(int argc, char *argv[])
while ((opt = getopt(argc, argv, "s:u:")) != -1) {
switch (opt) {
case 's':
- namespaces = optarg;
+ extend_namespaces(&namespaces, optarg);
+ printf("namespaces is %s\n", namespaces);
break;
case 'u':
uid = lookup_user(optarg);
--
1.6.3.3
next reply other threads:[~2010-05-13 19:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 19:34 Serge E. Hallyn [this message]
[not found] ` <20100513193412.GA15433-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-05-13 19:34 ` [PATCH lxc 2/2] lxc-unshare: make CLONE_NEWPID imply CLONE_NEWNS Serge E. Hallyn
[not found] ` <20100513193447.GA15830-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2010-05-18 16:01 ` Daniel Lezcano
2010-05-18 15:49 ` [PATCH lxc 1/2] lxc-unshare: accept multiple -s options Daniel Lezcano
[not found] ` <4BF2B71A.8020906-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org>
2010-05-18 16:07 ` Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100513193412.GA15433@us.ibm.com \
--to=serue-r/jw6+rmf7hqt0dzr+alfa@public.gmane.org \
--cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
--cc=dlezcano-NmTC/0ZBporQT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.