From: Marcelo Tosatti <mtosatti@redhat.com>
To: Avi Kivity <avi@redhat.com>
Cc: kvm@vger.kernel.org, Sheng Yang <sheng@linux.intel.com>
Subject: Re: [PATCH] KVM: MMU: Segregate shadow pages with different cr0.wp
Date: Thu, 13 May 2010 19:31:28 -0300 [thread overview]
Message-ID: <20100513223128.GC27620@amt.cnet> (raw)
In-Reply-To: <1273654098-1543-1-git-send-email-avi@redhat.com>
On Wed, May 12, 2010 at 11:48:18AM +0300, Avi Kivity wrote:
> When cr0.wp=0, we may shadow a gpte having u/s=1 and r/w=0 with an spte
> having u/s=0 and r/w=1. This allows excessive access if the guest sets
> cr0.wp=1 and accesses through this spte.
>
> Fix by making cr0.wp part of the base role; we'll have different sptes for
> the two cases and the problem disappears.
>
> Signed-off-by: Avi Kivity <avi@redhat.com>
> ---
> Documentation/kvm/mmu.txt | 2 ++
> arch/x86/include/asm/kvm_host.h | 1 +
> arch/x86/kvm/mmu.c | 3 ++-
> 3 files changed, 5 insertions(+), 1 deletions(-)
Applied, thanks.
prev parent reply other threads:[~2010-05-14 18:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-12 8:48 [PATCH] KVM: MMU: Segregate shadow pages with different cr0.wp Avi Kivity
2010-05-13 22:31 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100513223128.GC27620@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.