From: Marcelo Tosatti <mtosatti@redhat.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH] device-assignment: fix failure to exit on shared IRQ
Date: Thu, 13 May 2010 19:41:31 -0300 [thread overview]
Message-ID: <20100513224131.GD27620@amt.cnet> (raw)
In-Reply-To: <20100512091210.3097.57000.stgit@virtlab9.virt.bos.redhat.com>
On Wed, May 12, 2010 at 05:12:10AM -0400, Alex Williamson wrote:
> Since c1699988, piix config space isn't programmed until the first
> system reset. This means that when we call assign_irq() from
> assigned_initfn(), we're going to get back an irq of 0x0, which
> unfortunately matches our initialization value, so we don't bother
> to call kvm_assign_irq(). Switch to a -1 initializer so we can
> test whether kvm_assign_irq() is going to succeed and allow the
> process to exit if it doesn't. The guest irq will get reset to a
> more appropriate value on system reset anyway.
>
> Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Applied, thanks.
prev parent reply other threads:[~2010-05-14 18:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-12 9:12 [PATCH] device-assignment: fix failure to exit on shared IRQ Alex Williamson
2010-05-12 19:54 ` Chris Wright
2010-05-13 22:41 ` Marcelo Tosatti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100513224131.GD27620@amt.cnet \
--to=mtosatti@redhat.com \
--cc=alex.williamson@redhat.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.