From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [linux-pm] [PATCH 0/8] Suspend block api (version 6) Date: Thu, 13 May 2010 23:14:22 +0200 Message-ID: <201005132314.22497.rjw@sisk.pl> References: <20100513191717.GA3428@atomide.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20100513191717.GA3428@atomide.com> Sender: linux-kernel-owner@vger.kernel.org To: Tony Lindgren Cc: Alan Stern , Paul Walmsley , Arve =?iso-8859-1?q?Hj=F8nnev=E5g?= , Linux-pm mailing list , Kernel development list , Tejun Heo , Oleg Nesterov , Kevin Hilman , magnus.damm@gmail.com, Theodore Ts'o , mark gross , Arjan van de Ven , Geoff Smith , Brian Swetland , Matthew Garrett , =?iso-8859-1?q?Beno=EEt_Cousson?= , linux-omap@vger.kernel.org, Vitaly Wool , Linus Walleij , Mark Brown , Liam Girdwood List-Id: linux-omap@vger.kernel.org On Thursday 13 May 2010, Tony Lindgren wrote: > * Alan Stern [100513 07:11]: > > On Wed, 12 May 2010, Paul Walmsley wrote: > > > > > Hello, > > > > > > Some general comments on the suspend blockers/wakelock/opportunistic > > > suspend v6 patch series, posted here: > > > > > > https://lists.linux-foundation.org/pipermail/linux-pm/2010-April/025146.html > > > > > > The comments below are somewhat telegraphic in the interests of > > > readability - more specific comments to follow in later E-mails. I am > > > indebted to those of us who discussed these issues at LPC last year and > > > ELC this year for several stimulating discussions. > > > > > > There are several general problems with the design of opportunistic > > > suspend and suspend-blocks. > > > > > > 1. The opportunistic suspend code bypasses existing Linux kernel code, > > > such as timers and the scheduler, that indicates when code > > > needs to run, and when the system is idle. > > > > Whoa! That's not my understanding at all. > > > > As I see it, opportunistic suspend doesn't bypass any code that isn't > > already bypassed by the existing suspend code. Users can do > > > > echo mem >/sys/power/state > > > > whenever they want, without regard to kernel timers and the scheduler > > (other than the fact that the user's thread must be running in order to > > carry out the write, of course). > > The difference between echo mem > /sys/power/state and suspend blocks > is that with suspend blocks the system keeps running. Care to elaborate? Rafael