From: Dan Carpenter <error27@gmail.com>
To: Sage Weil <sage@newdream.net>
Cc: ceph-devel@vger.kernel.org
Subject: bug report: potential null deref send_mds_reconnect()
Date: Fri, 14 May 2010 01:36:16 +0200 [thread overview]
Message-ID: <20100513233615.GD5695@bicker> (raw)
This is a Smatch thing.
fs/ceph/mds_client.c +2217 send_mds_reconnect(82) error: we previously assumed 'session' could be null.
2176 down_read(&mdsc->snap_rwsem);
2177
2178 if (!session)
2179 goto send;
If we hit this goto then we will dereference session and oops.
2180 dout("session %p state %s\n", session,
2181 session_state_name(session->s_state));
regards,
dan carpenter
next reply other threads:[~2010-05-13 23:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-13 23:36 Dan Carpenter [this message]
2010-05-14 4:22 ` bug report: potential null deref send_mds_reconnect() Sage Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100513233615.GD5695@bicker \
--to=error27@gmail.com \
--cc=ceph-devel@vger.kernel.org \
--cc=sage@newdream.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.