All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Patrick McHardy <kaber@trash.net>
Cc: Chris Wright <chrisw@redhat.com>,
	Scott Feldman <scofeldm@cisco.com>,
	davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [net-next-2.6 V6 PATCH 1/2] Add netlink support for virtual port management (was iovnl)
Date: Fri, 14 May 2010 09:17:28 +0200	[thread overview]
Message-ID: <201005140917.28655.arnd@arndb.de> (raw)
In-Reply-To: <4BEC6B19.1040808@trash.net>

On Thursday 13 May 2010, Patrick McHardy wrote:
> > +enum {
> > +     VF_PORT_REQUEST_PREASSOCIATE = 0,
> > +     VF_PORT_REQUEST_PREASSOCIATE_RR,
> > +     VF_PORT_REQUEST_ASSOCIATE,
> > +     VF_PORT_REQUEST_DISASSOCIATE,
> > +};
> 
> Do multiple of these commands have to be issued in order to
> reach "associated" state? That also wouldn't fit into the
> rtnetlink design, which contains state, not commands.

In 802.1Qbg (see http://www.ieee802.org/1/files/public/docs2010/bg-joint-evb-0410v1.pdf)
they are defined both as state and as commands. I suggested
using the same definition so that we can use the exact values
when forming or receiving a TLV for the VDP protocol. We can change
freely between the first three during guest migration, but the port
(identified by the UUID) can only be in associate state on one
machine, and the switches would use that information to redirect
the data flow to the target of the migration.

The disassociate state is a bit strange in netlink because it
essentially means that the other information is now invalid,
but I'm not sure if there is a good alternative. If the switch
tells us that it is setting the link into disassociate state,
that should still be visible in netlink.

	Arnd

  parent reply	other threads:[~2010-05-14  7:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-13 20:17 [net-next-2.6 V6 PATCH 0/2] Add virtual port netlink support Scott Feldman
2010-05-13 20:17 ` [net-next-2.6 V6 PATCH 1/2] Add netlink support for virtual port management (was iovnl) Scott Feldman
2010-05-13 20:28   ` Chris Wright
2010-05-13 20:40   ` Patrick McHardy
2010-05-13 20:46     ` Chris Wright
2010-05-13 20:49       ` Patrick McHardy
2010-05-13 21:08         ` Chris Wright
2010-05-13 21:11           ` Patrick McHardy
2010-05-13 21:18             ` Chris Wright
2010-05-13 21:23               ` Patrick McHardy
2010-05-14  7:17             ` Arnd Bergmann [this message]
2010-05-13 21:30     ` Scott Feldman
2010-05-14 10:47       ` Patrick McHardy
2010-05-13 20:17 ` [net-next-2.6 V6 PATCH 2/2] Add ndo_{set|get}_vf_port support for enic dynamic vnics Scott Feldman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201005140917.28655.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=chrisw@redhat.com \
    --cc=davem@davemloft.net \
    --cc=kaber@trash.net \
    --cc=netdev@vger.kernel.org \
    --cc=scofeldm@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.