From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dan Carpenter <error27@gmail.com>
Subject: bug report: "drm/radeon/kms: HDMI irq support"
Date: Fri, 14 May 2010 13:29:27 +0200
Message-ID: <20100514112927.GF5695@bicker>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <dri-devel-bounces@lists.sourceforge.net>
Content-Disposition: inline
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.sourceforge.net?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=dri-devel>
List-Post: <mailto:dri-devel@lists.sourceforge.net>
List-Help: <mailto:dri-devel-request@lists.sourceforge.net?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.sourceforge.net?subject=subscribe>
Errors-To: dri-devel-bounces@lists.sourceforge.net
To: Christian Koenig <deathsimple@vodafone.de>
Cc: dri-devel@lists.sourceforge.net
List-Id: dri-devel@lists.freedesktop.org

Smatch complains about something from: f2594933df97 "drm/radeon/kms:
HDMI irq support"

drivers/gpu/drm/radeon/r600_hdmi.c +557 r600_hdmi_disable(20) error:
	offset is never equal to 29696 (wrong type 0 - 255).
+
+       /* disable irq */
+       rdev->irq.hdmi[offset == R600_HDMI_BLOCK1 ? 0 : 1] = false;
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^
	offset is 8 bits so this condition is always false.

+       radeon_irq_set(rdev);
+

regards,
dan carpenter


------------------------------------------------------------------------------

--