From: Borislav Petkov <bp@amd64.org>
To: Tom Zanussi <tzanussi@gmail.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@elte.hu>,
Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf/trace: use read() instead of lseek() in trace_event_read.c:skip()
Date: Fri, 14 May 2010 18:12:55 +0200 [thread overview]
Message-ID: <20100514161255.GA8535@kryptos.osrc.amd.com> (raw)
In-Reply-To: <1273032130.6383.28.camel@tropicana>
From: Tom Zanussi <tzanussi@gmail.com>
Date: Tue, May 04, 2010 at 11:02:10PM -0500
Hi,
> Here's a small fix for a problem affecting live-mode, introduced in the
> past day or so:
>
> root@tropicana:~# perf trace rwtop
> perf trace started with Perl
> script /root/libexec/perf-core/scripts/perl/rwtop.pl
>
> Fatal: did not read header event
>
> commit d00a47cce569a3e660a8c9de5d57af28d6a9f0f7 added a skip()
> function to skip over e.g. header_page, but this doesn't work for live
> mode. This patch re-implements skip() to use read() instead of
> lseek() to fix that.
>
> Signed-off-by: Tom Zanussi <tzanussi@gmail.com>
has this one landed in any tree in the meantime?
tip/perf/core doesn't have it.
--
Regards/Gruss,
Boris.
Operating Systems Research Center
Advanced Micro Devices, Inc.
next prev parent reply other threads:[~2010-05-14 16:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-05 4:02 [PATCH] perf/trace: use read() instead of lseek() in trace_event_read.c:skip() Tom Zanussi
2010-05-14 16:12 ` Borislav Petkov [this message]
2010-05-14 16:22 ` Frederic Weisbecker
2010-05-20 12:54 ` [tip:perf/core] perf: Use " tip-bot for Tom Zanussi
2010-05-20 13:39 ` Pekka Enberg
2010-05-20 13:41 ` H. Peter Anvin
2010-05-20 13:43 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100514161255.GA8535@kryptos.osrc.amd.com \
--to=bp@amd64.org \
--cc=acme@ghostprotocols.net \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.