From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Patrick McHardy <kaber@trash.net>
Cc: netfilter-devel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCHv2] netfilter: Remove skb_is_nonlinear check from nf_conntrack_sip
Date: Fri, 14 May 2010 13:56:55 -0600 [thread overview]
Message-ID: <20100514195655.GK15969@obsidianresearch.com> (raw)
In-Reply-To: <4BED99A3.2050404@trash.net>
On Fri, May 14, 2010 at 08:42:43PM +0200, Patrick McHardy wrote:
> > Should this be NF_DROP? As I understand it skb_linearize only failes
> > if it runs out of memory, which probably means dropping is OK. But
> > passing a packet that might need rewriting could be harmful..
>
> We so far also didn't rewrite the packet. But agreed, its
> a corner case and dropping it is the safer choice.
I was just thinking that, say, a request goes out, gets rewritten but
the reply comes back and does not get rewritten = bad. Better to drop.
Looks OK to me..
Jason
next prev parent reply other threads:[~2010-05-14 19:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-14 18:01 [PATCHv2] netfilter: Remove skb_is_nonlinear check from nf_conntrack_sip Jason Gunthorpe
2010-05-14 18:13 ` Patrick McHardy
2010-05-14 18:26 ` Jason Gunthorpe
2010-05-14 18:42 ` Patrick McHardy
2010-05-14 19:26 ` Patrick McHardy
2010-05-14 19:33 ` Jan Engelhardt
2010-05-14 19:41 ` Patrick McHardy
2010-05-14 19:56 ` Jason Gunthorpe [this message]
2010-05-14 18:33 ` Jan Engelhardt
2010-05-14 18:45 ` Patrick McHardy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100514195655.GK15969@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=kaber@trash.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.