From: Al Viro <viro@ZenIV.linux.org.uk>
To: Eric Paris <eparis@redhat.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, npiggin@suse.de
Subject: Re: [PATCH] anon_inode: set S_IFREG on the anon_inode
Date: Fri, 14 May 2010 21:23:30 +0100 [thread overview]
Message-ID: <20100514202329.GX30031@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20100514200555.17387.92658.stgit@paris.rdu.redhat.com>
On Fri, May 14, 2010 at 04:05:59PM -0400, Eric Paris wrote:
> anon_inode_mkinode() sets inode->i_mode = S_IRUSR | S_IWUSR; This means
> that (inode->i_mode & S_IFMT) == 0. This trips up some SELinux code that
> needs to determine if a given inode is a regular file, a directory, etc.
> The easiest solution is to just make sure that the anon_inode also sets
> S_IFREG.
How urgent that one is? It is obvious enough, so I could include it into
the pull request for -final, but...
next prev parent reply other threads:[~2010-05-14 20:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-14 20:05 [PATCH] anon_inode: set S_IFREG on the anon_inode Eric Paris
2010-05-14 20:23 ` Al Viro [this message]
2010-05-14 20:26 ` Eric Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100514202329.GX30031@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=eparis@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.