From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [linux-pm] [PATCH 0/8] Suspend block api (version 6) Date: Fri, 14 May 2010 23:25:07 +0200 Message-ID: <201005142325.08061.rjw@sisk.pl> References: <201005132356.21355.rjw@sisk.pl> <878w7mgqse.fsf@deeprootsystems.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: Received: from ogre.sisk.pl ([217.79.144.158]:58228 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752719Ab0ENVYI (ORCPT ); Fri, 14 May 2010 17:24:08 -0400 In-Reply-To: <878w7mgqse.fsf@deeprootsystems.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Kevin Hilman Cc: Tony Lindgren , Matthew Garrett , Alan Stern , Paul Walmsley , Arve =?iso-8859-1?q?Hj=F8nnev=E5g?= , Linux-pm mailing list , Kernel development list , Tejun Heo , Oleg Nesterov , magnus.damm@gmail.com, Theodore Ts'o , mark gross , Arjan van de Ven , Geoff Smith , Brian Swetland , =?iso-8859-1?q?Beno=EEt_Cousson?= , linux-omap@vger.kernel.org, Vitaly Wool , Mark Brown , Liam Girdwood On Friday 14 May 2010, Kevin Hilman wrote: > "Rafael J. Wysocki" writes: > > > On Thursday 13 May 2010, Tony Lindgren wrote: > >> * Rafael J. Wysocki [100513 14:16]: > > [...] > > >> > >> > It solves a practical issue that _at_ _the_ _moment_ cannot be solved > >> > differently, while there's a growing number of out-of-tree drivers depending > >> > on this framework. We need those drivers in and because we don't have any > >> > viable alternative at hand, we have no good reason to reject it. > >> > >> Nothing is preventing merging the drivers can be merged without > >> these calls. > > > > And yet, there _is_ a growing nuber of drivers that don't get merge because > > of that. That's _reality_. Are you going to discuss with facts, or what? > > It may be reality, but IMO, "preventing other drivers" isn't a good > *technical* argument for merging a feature. It feels like these "for > the 'good' of the community" arguments are being used to trump the > technical arguments. Maybe we need to keep the separate. > > Distros (especially embedded ones) have long had out of tree features > that create barriers to getting other drivers upstream. While it > might be nice to see all those features upstream, no one has argued > that they should get merged simply because they create a barrier. Each > feature should be merged on its own technical merit. Well, this is very much like the selinux vs apparmour (& friends) issue. One can argue we need only one of them, but in fact we're not worse off having both in. The feature is not technically unacceptable to me and since having it in would potentially make it easier to merge quite a few drivers, I regard that as a good enough argument for. YMMV. Thanks, Rafael