From: Arnd Bergmann <arnd@arndb.de>
To: Chris Wright <chrisw@sous-sol.org>
Cc: davem@davemloft.net, kaber@trash.net, mitch.a.williams@intel.com,
scofeldm@cisco.com, shemminger@vyatta.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] rtnetlink: make SR-IOV VF interface symmetric
Date: Sat, 15 May 2010 11:04:40 +0200 [thread overview]
Message-ID: <201005151104.41158.arnd@arndb.de> (raw)
In-Reply-To: <20100515031416.GE15313@sequoia.sous-sol.org>
On Saturday 15 May 2010 05:14:16 Chris Wright wrote:
> Now we have a set of nested attributes:
>
> IFLA_VFINFO_LIST (NESTED)
> IFLA_VF_INFO (NESTED)
> IFLA_VF_MAC
> IFLA_VF_VLAN
> IFLA_VF_TX_RATE
>
> This allows a single set to operate on multiple attributes if desired.
> Among other things, it means a dump can be replayed to set state.
>
> The current interface has yet to be released, so this seems like
> something to consider for 2.6.34.
>
> Signed-off-by: Chris Wright <chrisw@sous-sol.org
Very nice! This would be the minimum change to make the ABI conform
to the general rules, so it would be really good to have that.
Acked-by: Arnd Bergmann <arnd@arndb.de>
It does make the interface a bit strange (less than before), since the
new IFLA_VF_INFO now contains three nested attributes that each contain their
own vf number field, and we don't require that they are identical or that
each of the nested attributes inside VF_INFO appears only once.
How about a second patch that splits out an IFLA_VF_NUMBER attribute
and makes do_setvfinfo use nla_parse_nested instead of nla_for_each_nested
in order to tighten the rules on this some more?
Arnd
next prev parent reply other threads:[~2010-05-15 9:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-15 3:14 [PATCH] rtnetlink: make SR-IOV VF interface symmetric Chris Wright
2010-05-15 9:04 ` Arnd Bergmann [this message]
2010-05-17 16:10 ` Chris Wright
2010-05-16 8:05 ` David Miller
2010-05-17 15:59 ` Stephen Hemminger
2010-05-17 16:02 ` Williams, Mitch A
2010-05-17 16:07 ` Chris Wright
2010-05-17 16:55 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005151104.41158.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=chrisw@sous-sol.org \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
--cc=scofeldm@cisco.com \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.