From: Samuel Ortiz <sameo@linux.intel.com>
To: Rabin Vincent <rabin.vincent@stericsson.com>
Cc: linux-kernel@vger.kernel.org,
STEricsson_nomadik_linux@list.st.com,
Linus Walleij <linus.walleij@stericsson.com>,
Srinidhi Kasagar <srinidhi.kasagar@stericsson.com>
Subject: Re: [PATCH] mfd: new AB8500 driver
Date: Mon, 17 May 2010 00:53:55 +0200 [thread overview]
Message-ID: <20100516225355.GF3236@sortiz.org> (raw)
In-Reply-To: <1273553131-9312-1-git-send-email-rabin.vincent@stericsson.com>
Hi Rabin,
On Tue, May 11, 2010 at 10:15:31AM +0530, Rabin Vincent wrote:
> Add a new driver to support the AB8500 Power Management chip, replacing
> the current AB4500. The new driver replaces the old one, instead of an
> incremental modification, because this is a substantial overhaul
> including:
>
> - Split of the driver into -core and -spi portions, to allow another
> interface layer to be added
>
> - Addition of interrupt support
>
> - Switch to MFD core API for handling subdevices
>
> - Simplification of the APIs to remove a redundant block parameter
>
> - Rename of the APIs and macros from ab4500_* to ab8500_*
>
> - Rename of the files from ab4500* to ab8500*
>
> The driver still identifes itself as "ab4500"
The patch looks good, but why not changing that to "ab8500" and integrating
the relevant board file changes to this patch ?
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2010-05-16 22:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-11 4:45 [PATCH] mfd: new AB8500 driver Rabin Vincent
2010-05-16 22:53 ` Samuel Ortiz [this message]
2010-05-17 16:00 ` Rabin VINCENT
2010-05-18 23:23 ` Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100516225355.GF3236@sortiz.org \
--to=sameo@linux.intel.com \
--cc=STEricsson_nomadik_linux@list.st.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rabin.vincent@stericsson.com \
--cc=srinidhi.kasagar@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.