All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Vorontsov <cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Joakim Tjernlund
	<Joakim.Tjernlund-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org>
Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH] spi: spi_mpc8xxx.c: Do not use map_tx_dma to unmap rx_dma
Date: Mon, 17 May 2010 17:22:54 +0400	[thread overview]
Message-ID: <20100517132254.GA6567@oksana.dev.rtsoft.ru> (raw)
In-Reply-To: <1274102230-20828-1-git-send-email-Joakim.Tjernlund-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org>

On Mon, May 17, 2010 at 03:17:10PM +0200, Joakim Tjernlund wrote:
> This fixes a typo were map_tx_dma is used instead of
> map_rx_dma, casing the driver to unmap rx_dma when it
> shouldn't.
> 
> Signed-off-by: Joakim Tjernlund <Joakim.Tjernlund-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org>

Acked-by: Anton Vorontsov <cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Thanks!

> ---
>  drivers/spi/spi_mpc8xxx.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/spi/spi_mpc8xxx.c b/drivers/spi/spi_mpc8xxx.c
> index c85dbbb..2d54020 100644
> --- a/drivers/spi/spi_mpc8xxx.c
> +++ b/drivers/spi/spi_mpc8xxx.c
> @@ -514,7 +514,7 @@ static void mpc8xxx_spi_cpm_bufs_complete(struct mpc8xxx_spi *mspi)
>  
>  	if (mspi->map_tx_dma)
>  		dma_unmap_single(dev, mspi->tx_dma, t->len, DMA_TO_DEVICE);
> -	if (mspi->map_tx_dma)
> +	if (mspi->map_rx_dma)
>  		dma_unmap_single(dev, mspi->rx_dma, t->len, DMA_FROM_DEVICE);
>  	mspi->xfer_in_progress = NULL;
>  }
> -- 
> 1.6.4.4

-- 
Anton Vorontsov
email: cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
irc://irc.freenode.net/bd2

------------------------------------------------------------------------------

  parent reply	other threads:[~2010-05-17 13:22 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-17 13:17 [PATCH] spi: spi_mpc8xxx.c: Do not use map_tx_dma to unmap rx_dma Joakim Tjernlund
     [not found] ` <1274102230-20828-1-git-send-email-Joakim.Tjernlund-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org>
2010-05-17 13:22   ` Anton Vorontsov [this message]
     [not found]     ` <20100517132254.GA6567-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org>
2010-05-21 17:23       ` Joakim Tjernlund
     [not found]         ` <OFD8B30A94.BD9EA490-ONC125772A.005F631A-C125772A.005F8E73-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org>
2010-05-22  5:54           ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100517132254.GA6567@oksana.dev.rtsoft.ru \
    --to=cbouatmailru-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=Joakim.Tjernlund-SNLAxHN9vbcOP4wsBPIw7w@public.gmane.org \
    --cc=spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.