All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave McCracken <dcm@mccr.org>
To: Keir Fraser <Keir.Fraser@eu.citrix.com>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
	Xen Developers List <xen-devel@lists.xensource.com>
Subject: [PATCH] Allow PV superpages to work with live migration
Date: Mon, 17 May 2010 14:10:46 -0500	[thread overview]
Message-ID: <201005171410.47235.dcm@mccr.org> (raw)

[-- Attachment #1: Type: Text/Plain, Size: 360 bytes --]


PV superpages currently do not work with live migration.  They fall over dead 
when the shadow page table is enabled for dirty tracking.  The HVM support for 
superpages in this code has been tested and found to work just fine for PV 
superpages.  This patch modifies the test macro to allow the code to work with 
PV superpages.

Dave McCracken
Oracle Corp.

[-- Attachment #2: xen-unstable-smigrate-1.patch --]
[-- Type: text/x-patch, Size: 824 bytes --]

--- xen-unstable//xen/include/asm-x86/guest_pt.h	2010-04-19 09:23:24.000000000 -0500
+++ xen-hmigrate//xen/include/asm-x86/guest_pt.h	2010-05-17 14:00:34.000000000 -0500
@@ -186,10 +186,11 @@ guest_supports_superpages(struct vcpu *v
     /* The _PAGE_PSE bit must be honoured in HVM guests, whenever
      * CR4.PSE is set or the guest is in PAE or long mode. 
      * It's also used in the dummy PT for vcpus with CR4.PG cleared. */
-    return (is_hvm_vcpu(v) && 
-            (GUEST_PAGING_LEVELS != 2 
-             || !hvm_paging_enabled(v)
-             || (v->arch.hvm_vcpu.guest_cr[4] & X86_CR4_PSE)));
+    return (opt_allow_hugepage ||
+	    (is_hvm_vcpu(v) && 
+	     (GUEST_PAGING_LEVELS != 2 
+	      || !hvm_paging_enabled(v)
+	      || (v->arch.hvm_vcpu.guest_cr[4] & X86_CR4_PSE))));
 }
 
 static inline int

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

             reply	other threads:[~2010-05-17 19:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-17 19:10 Dave McCracken [this message]
2010-05-18 12:35 ` [PATCH] Allow PV superpages to work with live migration Tim Deegan
2010-05-18 14:20   ` Dave McCracken
2010-05-18 14:32     ` Tim Deegan
2010-05-18 14:33       ` Keir Fraser
2010-05-18 16:21       ` Dave McCracken

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201005171410.47235.dcm@mccr.org \
    --to=dcm@mccr.org \
    --cc=Keir.Fraser@eu.citrix.com \
    --cc=jeremy@goop.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.