From: Chris Mason <chris.mason@oracle.com>
To: Jakob Unterwurzacher <jakobunt@gmail.com>
Cc: linux-btrfs@vger.kernel.org
Subject: Re: Rename+crash behaviour of btrfs - nearly ext3!
Date: Mon, 17 May 2010 15:36:52 -0400 [thread overview]
Message-ID: <20100517193652.GC8635@think> (raw)
In-Reply-To: <4BF18525.8080904@gmail.com>
On Mon, May 17, 2010 at 08:04:21PM +0200, Jakob Unterwurzacher wrote:
> Hi!
>
> Following Ubuntu's dpkg+ext4 problems I wanted to see if btrfs would
> solve them all. And it nearly does! Now I wonder if the remaining 0.2
> seconds window of exposing 0-size files could be closed too.
That should be a zero second window, we try to force things to disk
during renames.
Could you please try this patch:
diff --git a/fs/btrfs/ordered-data.c b/fs/btrfs/ordered-data.c
index c9f1020..9370a71 100644
--- a/fs/btrfs/ordered-data.c
+++ b/fs/btrfs/ordered-data.c
@@ -806,7 +806,7 @@ int btrfs_add_ordered_operation(struct btrfs_trans_handle *trans,
* if this file hasn't been changed since the last transaction
* commit, we can safely return without doing anything
*/
- if (last_mod < root->fs_info->last_trans_committed)
+ if (0 && last_mod < root->fs_info->last_trans_committed)
return 0;
/*
next prev parent reply other threads:[~2010-05-17 19:36 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-17 18:04 Rename+crash behaviour of btrfs - nearly ext3! Jakob Unterwurzacher
2010-05-17 19:12 ` Ric Wheeler
2010-05-17 19:25 ` Josef Bacik
2010-05-17 20:09 ` Chris Mason
2010-05-17 20:30 ` Jakob Unterwurzacher
2010-05-17 19:36 ` Chris Mason [this message]
2010-05-18 0:14 ` Jakob Unterwurzacher
2010-05-18 0:30 ` Chris Mason
2010-05-18 0:59 ` Chris Mason
2010-05-18 12:03 ` Jakob Unterwurzacher
2010-05-18 13:13 ` Chris Mason
2010-05-18 13:28 ` Oystein Viggen
2010-05-18 14:47 ` Thomas Bellman
2010-05-18 13:39 ` Aidan Van Dyk
2010-05-18 14:06 ` Jakob Unterwurzacher
2010-05-18 14:36 ` Chris Mason
2010-05-18 15:57 ` Jakob Unterwurzacher
2010-05-18 16:10 ` Chris Mason
2010-05-18 18:01 ` Goffredo Baroncelli
2010-05-18 18:24 ` Jakob Unterwurzacher
2010-05-18 23:00 ` Ric Wheeler
2010-05-19 1:05 ` Bruce Guenter
2010-05-19 1:34 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100517193652.GC8635@think \
--to=chris.mason@oracle.com \
--cc=jakobunt@gmail.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.