Re: [PATCH] Adding support for new keys (ASSIST, WEB and VAIO) of the laptop Vaio E Series.

[Mattia Dongili <malattia@linux.it>]

Hi Jorge

On Sun, May 16, 2010 at 03:36:52AM -0300, Jorge Pereira wrote:
> Hi!
> 
>  Recently i bought the sony laptop model 'VPCEB15FB' and this model
> has Three buttons top of keyboard[1] that don't work until then.
> added support to all three keys at the driver sony-laptop.c and sonypi.h

Thanks for the patch, it's fundamentally ok but to be honest I'm not too
convinced about the naming. I'm not sure how "dedicated" the Web will
be after you pressed the DEDICATED_WEB button. :)
Also, you seem to have patched an old version of the driver, please
make sure the patch applies on current code.

See a couple of comments below.

...
> From d2c812270bfce82da57a88c40f43a7eea42ba1f2 Mon Sep 17 00:00:00 2001
> From: Jorge Pereira <jpereiran@gmail.com>
> Date: Fri, 14 May 2010 18:18:19 -0300
> Subject: [PATCH] Adding support for new keys (ASSIST, WEB and VAIO) of the laptop Vaio E Series.
> 
> ---

Please also Sign-off the patch in your commit log.

...
> +	58, /* 72 SONYPI_EVENT_DEDICATED_SUPPORT */
> +	59, /* 73 SONYPI_EVENT_DEDICATED_WEB */
> +	60, /* 74 SONYPI_EVENT_DEDICATED_VAIO */

Can't these just be SONYPY_EVENT_ASSIST_PRESSED,
SONYPI_EVENT_WEB_PRESSED and SONYPI_EVENT_VAIO_PRESSED?
If necessary you can describe what they were originally inteded to in
the commit message.

Thanks!
-- 
mattia
:wq!