All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amit Shah <amit.shah@redhat.com>
To: Steven Liu <lingjiujianke@gmail.com>
Cc: linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org
Subject: Re: [PATCH] fix a code style in drivers/char/virtio_console.c
Date: Tue, 18 May 2010 10:52:30 +0530	[thread overview]
Message-ID: <20100518052230.GA1706@amit-laptop.redhat.com> (raw)
In-Reply-To: <AANLkTilW8zZxCOrdiefZ4ZtixprI58LzDZ6Cz03z4lFk@mail.gmail.com>

On (Tue) May 18 2010 [13:17:22], Steven Liu wrote:
> fix a code style in drivers/char/virtio_console.c
> 
> Signed-off-by: Liu Qi <lingjiujianke@gmail.com>

NACK.

This style is deliberate and follows Rusty's style: if we end up using
'err' uninitialised in some code path, it can get flagged by source
checkers.

		Amit

  parent reply	other threads:[~2010-05-18  5:21 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-18  5:17 [PATCH] fix a code style in drivers/char/virtio_console.c Steven Liu
2010-05-18  5:22 ` Amit Shah
2010-05-18  5:22 ` Amit Shah [this message]
2010-05-18  5:41   ` Steven Liu
2010-05-18  5:41   ` Steven Liu
2010-05-18  6:32     ` Amit Shah
2010-05-18  6:32     ` Amit Shah
2010-05-18  6:41       ` Steven Liu
2010-05-18  6:41       ` Steven Liu
  -- strict thread matches above, loose matches on Subject: below --
2010-05-18  5:17 Steven Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100518052230.GA1706@amit-laptop.redhat.com \
    --to=amit.shah@redhat.com \
    --cc=lingjiujianke@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.