From: Stephen Hemminger <shemminger@vyatta.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: David Miller <davem@davemloft.net>,
jbohac@suse.cz, yoshfuji@linux-ipv6.org, netdev@vger.kernel.org
Subject: Re: [0/4] Fix addrconf race conditions
Date: Tue, 18 May 2010 10:25:50 -0700 [thread overview]
Message-ID: <20100518102550.65ad3fdd@nehalam> (raw)
In-Reply-To: <20100518110243.GA7750@gondor.apana.org.au>
On Tue, 18 May 2010 21:02:43 +1000
Herbert Xu <herbert@gondor.apana.org.au> wrote:
> On Fri, Apr 23, 2010 at 11:05:40PM +0800, Herbert Xu wrote:
> >
> > This stuff is more broken than I thought. For example, we perform
> > a number of actions when DAD succeeds, e.g., joining an anycast
> > group. However, this is not synchronised with respect to address
> > deletion at all, so if DAD succeeds just as someone deletes the
> > address, you can easily get stuck on that anycast group.
> >
> > I will try to untangle this mess tomorrow.
>
> Tomorrow took a while to arrive :)
>
> Here is a first batch of patches. Note that this is by no means
> a comprehensive fix for all the ndisc/addrconf race conditions.
> It is just a first step in trying to address the problems.
>
> The patchset revolves around a new lock, ifp->state_lock. I
> added it instead of trying to reuse the existing ifp->lock because
> the latter has serious nesting issues that prevent it from easily
> being used. My long term plan is to restructure the locking and
> eventually phase out ifp->lock in favour of ifp->state_lock.
I wonder if so many fine grained locks are really necessary at
all. Everything but timers looks like it is under RTNL mutex
already.
next prev parent reply other threads:[~2010-05-18 17:25 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-20 17:44 IPv6: race condition in __ipv6_ifa_notify() and dst_free() ? Jiri Bohac
2010-04-20 17:57 ` Eric Dumazet
2010-04-20 20:49 ` Jiri Bohac
2010-04-20 20:57 ` Eric Dumazet
2010-04-20 21:16 ` Stephen Hemminger
2010-04-20 21:35 ` Jiri Bohac
2010-04-21 21:34 ` Jiri Bohac
2010-04-22 2:32 ` Herbert Xu
2010-04-22 7:43 ` David Miller
2010-04-22 14:25 ` Herbert Xu
2010-04-22 15:49 ` Jiri Bohac
2010-04-22 16:17 ` Stephen Hemminger
2010-04-23 1:54 ` David Miller
2010-04-23 2:10 ` Herbert Xu
2010-04-23 15:05 ` Herbert Xu
2010-05-18 11:02 ` [0/4] Fix addrconf race conditions Herbert Xu
2010-05-18 11:04 ` [PATCH 1/4] ipv6: Replace inet6_ifaddr->dead with state Herbert Xu
2010-05-18 17:23 ` Stephen Hemminger
2010-05-18 22:27 ` David Miller
2010-05-18 11:04 ` [PATCH 2/4] ipv6: Use state_lock to protect ifa state Herbert Xu
2010-05-18 11:04 ` [PATCH 3/4] ipv6: Use POSTDAD state Herbert Xu
2010-05-18 11:04 ` [PATCH 4/4] ipv6: Never schedule DAD timer on dead address Herbert Xu
2010-05-18 17:25 ` Stephen Hemminger [this message]
2010-05-18 22:27 ` [0/4] Fix addrconf race conditions David Miller
2010-05-18 22:35 ` Herbert Xu
2010-04-27 15:50 ` IPv6: race condition in __ipv6_ifa_notify() and dst_free() ? Jiri Bohac
2010-04-27 15:55 ` Herbert Xu
2010-05-09 6:48 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100518102550.65ad3fdd@nehalam \
--to=shemminger@vyatta.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jbohac@suse.cz \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.