All of lore.kernel.org
 help / color / mirror / Atom feed
From: jacob pan <jacob.jun.pan@linux.intel.com>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
	"H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
	Alek Du <alek.du@intel.com>, Alan Cox <alan@linux.intel.com>,
	Feng Tang <feng.tang@intel.com>
Subject: Re: [PATCH 2/2] v4 x86/mrst: add more timer config options
Date: Tue, 18 May 2010 15:57:36 -0700	[thread overview]
Message-ID: <20100518155736.00007d03@unknown> (raw)
In-Reply-To: <alpine.LFD.2.00.1005182240480.3368@localhost.localdomain>


>>  
>> +/**
>
>  Do not use kerneldoc /** opener from plain comments. Randy
>  complained about that yesterday already
>
I missed randy's comment at the end. sorry. I admit I did not know kernel-doc
before that.

		if (mrst_identify_cpu() == MRST_CPU_CHIP_PENWELL) {
>
>  Why do you want to pin that on PENWELL and not on ARAT ? If you
>  check ARAT, you have coverd all next gen cpus as well.

I did try ARAT first but ARAT is not available at this point. the add-on cpu
features are set later.

Thanks,

Jacob

  reply	other threads:[~2010-05-18 22:57 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-05-18 12:02 [PATCH 0/2] v3 Moorestown clock related patches Jacob Pan
2010-05-18 12:02 ` [PATCH 1/2] v4 x86/mrst: add cpu type detection Jacob Pan
2010-05-18 20:54   ` Thomas Gleixner
2010-05-19  9:23     ` jacob pan
2010-05-19 10:19       ` Thomas Gleixner
2010-05-18 12:02 ` [PATCH 2/2] v4 x86/mrst: add more timer config options Jacob Pan
2010-05-18 20:50   ` Thomas Gleixner
2010-05-18 22:57     ` jacob pan [this message]
2010-05-18 23:00       ` Thomas Gleixner
2010-05-18 12:11 ` [PATCH 0/2] v3 Moorestown clock related patches jacob pan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100518155736.00007d03@unknown \
    --to=jacob.jun.pan@linux.intel.com \
    --cc=alan@linux.intel.com \
    --cc=alek.du@intel.com \
    --cc=feng.tang@intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.