From: Jarkko Nikula <jhnikula@gmail.com>
To: eduardo.valentin@nokia.com
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>
Subject: Re: [PATCH] si4713: Fix oops when si4713_platform_data is marked as __initdata
Date: Tue, 18 May 2010 16:24:45 +0300 [thread overview]
Message-ID: <20100518162445.5399d077.jhnikula@gmail.com> (raw)
In-Reply-To: <20100518125527.GB4265@besouro.research.nokia.com>
On Tue, 18 May 2010 15:55:27 +0300
Eduardo Valentin <eduardo.valentin@nokia.com> wrote:
> I'm probably fine with this patch, and the driver must check for the pointer
> before using it, indeed.
>
> But, I'm a bit skeptic about marking its platform data as __initdata. Would it make sense?
> What happens if driver is built as module and loaded / unload / loaded again?
>
> Maybe the initdata flag does not apply in this case. Not sure (and not tested the above case).
>
Yep, it doesn't work or make sense for modules if platform data is
marked as __initdata but with built in case it can save some bytes which
are not needed after kernel is initialized.
Like with this driver the i2c_bus number and i2_board_info data are not
needed after probing but only pointer to set_power must be preserved.
--
Jarkko
next prev parent reply other threads:[~2010-05-18 13:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-16 17:04 [PATCH] si4713: Fix oops when si4713_platform_data is marked as __initdata Jarkko Nikula
2010-05-18 12:55 ` Eduardo Valentin
2010-05-18 13:24 ` Jarkko Nikula [this message]
2010-07-05 16:09 ` Mauro Carvalho Chehab
2010-07-05 16:48 ` Jarkko Nikula
2010-07-05 18:25 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100518162445.5399d077.jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=eduardo.valentin@nokia.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.