From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=45382 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OEOXc-0008M7-IL
	for qemu-devel@nongnu.org; Tue, 18 May 2010 11:17:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <thomas_ml@monjalon.net>) id 1OEOXY-00019U-UY
	for qemu-devel@nongnu.org; Tue, 18 May 2010 11:17:08 -0400
Received: from mail.corp.accelance.fr ([213.162.48.15]:56925)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <thomas_ml@monjalon.net>) id 1OEOXX-00018o-V9
	for qemu-devel@nongnu.org; Tue, 18 May 2010 11:17:04 -0400
Received: from tmonjalo-laptop (LPuteaux-156-15-47-90.w82-127.abo.wanadoo.fr
	[82.127.74.90])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mail.corp.accelance.fr (Postfix) with ESMTP id 96AAD7EC28
	for <qemu-devel@nongnu.org>; Tue, 18 May 2010 17:16:49 +0200 (CEST)
From: Thomas Monjalon <thomas_ml@monjalon.net>
Subject: Re: [Qemu-devel] [PATCH v2 4/5] target-ppc: fix RFI by clearing upper
	bytes of MSR
Date: Tue, 18 May 2010 17:17:02 +0200
References: <cover.1272382040.git.thomas@monjalon.net>
	<201005181600.27913.thomas_ml@monjalon.net>
	<4BF2A5CE.8020709@suse.de>
In-Reply-To: <4BF2A5CE.8020709@suse.de>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="windows-1252"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <201005181717.03044.thomas_ml@monjalon.net>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Alexander Graf wrote:
> Thomas Monjalon wrote:
> > I'm running Linux for SBC834x in Qemu. The interrupt controller and board
> > definition are not yet published.
>
> Wow, I didn't know there were still new products based on e300.

Sorry, I was not clear. By "not yet published", I mean that I've written Qemu 
code to emulate e300 but I haven't yet send it to the ML. I would prefer to 
fix this RFI issue first.
SBC834x is not a new product.


> > From the e300 reference manual (e300CORERM):
> > "The TGPR bit is cleared by an rfi instruction."
> >
> > My first try was to clear only TGPR. But it doesn't work properly if POW
> > and ILE are not cleared.
>
> According to the 2.06 ISA again, rfi does the following:
>
> The contents of SRR1 are placed into the MSR. If the new MSR value does
> not enable any pending exceptions, then the next instruction is fetched,
> under control of the new MSR value, from the address SRR0 0:64 || 0b00.
>
> If rfi would clear ILE, how would it be enabled then?

You should be right. I have to fix a bug elsewhere.

-- 
Thomas