From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Nikula Subject: Re: [PATCH 2/2] omap: rx51: Add supplies and data for the tpa6130a2 headphone amplifier Date: Tue, 18 May 2010 20:51:09 +0300 Message-ID: <20100518205109.19e8ca86.jhnikula@gmail.com> References: <1274180761-14221-1-git-send-email-jhnikula@gmail.com> <1274180761-14221-2-git-send-email-jhnikula@gmail.com> <20100518124848.GA4265@besouro.research.nokia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from ey-out-2122.google.com ([74.125.78.27]:40822 "EHLO ey-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932085Ab0ERRvO (ORCPT ); Tue, 18 May 2010 13:51:14 -0400 Received: by ey-out-2122.google.com with SMTP id d26so617606eyd.19 for ; Tue, 18 May 2010 10:51:12 -0700 (PDT) In-Reply-To: <20100518124848.GA4265@besouro.research.nokia.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: eduardo.valentin@nokia.com Cc: "linux-omap@vger.kernel.org" , Tony Lindgren On Tue, 18 May 2010 15:48:48 +0300 Eduardo Valentin wrote: > > @@ -285,6 +287,9 @@ static struct regulator_consumer_supply rx51_vm= mc2_supplies[] =3D { > > /* tlv320aic3x analog supplies */ > > REGULATOR_SUPPLY("AVDD", "2-0018"), > > REGULATOR_SUPPLY("DRVDD", "2-0018"), > > + /* tpa6130a2 */ > > + REGULATOR_SUPPLY("CPVSS", "2-0060"), >=20 > Isn't CPVSS grounded? Well that wouldn't hurt to put it here, but it = doesnt belong to vmmc2 though. >=20 Thanks Eduardo! For me it looks this CPVSS supply is miss-added to the tpa6130a2 as spec says for this pin: "Negative supply generated by the charge pump. Decouple to pin 19 on the QFN or a CPVSS B2 15, 16 P GND plane. Use a 1 =CE=BCF capacitor." I'll send a fix first to the tpa6130a2 and repost this one after that. --=20 Jarkko -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html