From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Bowler Date: Wed, 19 May 2010 16:58:40 +0000 Subject: Re: [PATCH #upstream-fixes] libata: disable ATAPI AN by default Message-Id: <20100519165840.GA12642@elliptictech.com> List-Id: References: <20100518162350.GA29594@elliptictech.com> <4BF2D8E8.1040602@kernel.org> <4BF2DC55.5010209@kernel.org> <20100518192300.GA30821@elliptictech.com> <4BF3E64D.2040003@kernel.org> <4BF3E9F2.9050608@kernel.org> In-Reply-To: <4BF3E9F2.9050608@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Tejun Heo Cc: Jeff Garzik , "linux-ide@vger.kernel.org" , Kay Sievers , David Zeuthen , linux-hotplug@vger.kernel.org, stable@kernel.org On 15:38 Wed 19 May , Tejun Heo wrote: > There are ATAPI devices which raise AN when hit by commands issued by > open(). This leads to infinite loop of AN -> MEDIA_CHANGE uevent -> > udev open() to check media -> AN. > > Both ACS and SerialATA standards don't define in which case ATAPI > devices are supposed to raise or not raise AN. They both list media > insertion event as a possible use case for ATAPI ANs but there is no > clear description of what constitutes such events. As such, it seems > a bit too naive to export ANs directly to userland as MEDIA_CHANGE > events without further verification (which should behave similarly to > windows as it apparently is the only thing that some hardware vendors > are testing against). > > This patch adds libata.atapi_an module parameter and disables ATAPI AN > by default for now. Works here, drive now spins down properly. Tested-By: Nick Bowler -- Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/) From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Bowler Subject: Re: [PATCH #upstream-fixes] libata: disable ATAPI AN by default Date: Wed, 19 May 2010 12:58:40 -0400 Message-ID: <20100519165840.GA12642@elliptictech.com> References: <20100518162350.GA29594@elliptictech.com> <4BF2D8E8.1040602@kernel.org> <4BF2DC55.5010209@kernel.org> <20100518192300.GA30821@elliptictech.com> <4BF3E64D.2040003@kernel.org> <4BF3E9F2.9050608@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from dsl-67-204-24-19.acanac.net ([67.204.24.19]:46771 "EHLO emergent.ellipticsemi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751688Ab0ESQ7K (ORCPT ); Wed, 19 May 2010 12:59:10 -0400 Content-Disposition: inline In-Reply-To: <4BF3E9F2.9050608@kernel.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: Jeff Garzik , "linux-ide@vger.kernel.org" , Kay Sievers , David Zeuthen , linux-hotplug@vger.kernel.org, stable@kernel.org On 15:38 Wed 19 May , Tejun Heo wrote: > There are ATAPI devices which raise AN when hit by commands issued by > open(). This leads to infinite loop of AN -> MEDIA_CHANGE uevent -> > udev open() to check media -> AN. > > Both ACS and SerialATA standards don't define in which case ATAPI > devices are supposed to raise or not raise AN. They both list media > insertion event as a possible use case for ATAPI ANs but there is no > clear description of what constitutes such events. As such, it seems > a bit too naive to export ANs directly to userland as MEDIA_CHANGE > events without further verification (which should behave similarly to > windows as it apparently is the only thing that some hardware vendors > are testing against). > > This patch adds libata.atapi_an module parameter and disables ATAPI AN > by default for now. Works here, drive now spins down properly. Tested-By: Nick Bowler -- Nick Bowler, Elliptic Technologies (http://www.elliptictech.com/)