From: Thomas Renninger <trenn@suse.de>
To: Nishanth Menon <nm@ti.com>
Cc: Mike Chan <mike@android.com>,
"khilman@deeprootsystems.com" <khilman@deeprootsystems.com>,
"menage@google.com" <menage@google.com>,
"balbir@in.ibm.com" <balbir@in.ibm.com>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 4/4] omap: cpu: Power tracking support for cgroup cpuacct
Date: Wed, 19 May 2010 17:34:27 +0200 [thread overview]
Message-ID: <201005191734.27887.trenn@suse.de> (raw)
In-Reply-To: <4BF3E367.5080906@ti.com>
On Wednesday 19 May 2010 15:11:03 Nishanth Menon wrote:
> Mike Chan had written, on 05/18/2010 08:30 PM, the following:
> > Specify new power field in struct omap_opp, which is
> > power exported in milliWatt.
...
> > + totalpower += cpuacct_freq[i] * mpu_opps[i + 1].power;
...
> > + unsigned long power; /* power consumed running at OPP in
milliWatts */
>
> this conflicts with the OPP layer implementation. this structure will
> disappear for good.
Ah yes, another question:
The power variable in struct omap_opp never gets initialized
with a sane value, something is wrong...
Thomas
next prev parent reply other threads:[~2010-05-19 15:33 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-19 1:30 [PATCH 0/4] Enable cpu frequency and power tracking for cpuacct cgroup Mike Chan
2010-05-19 1:30 ` Mike Chan
2010-05-19 1:30 ` [PATCH 1/4] scheduler: cpuacct: Enable platform hooks to track cpuusage for CPU frequencies Mike Chan
2010-05-19 1:30 ` Mike Chan
2010-05-19 1:30 ` [PATCH 2/4] omap: cpu: Implement callbacks for cpu frequency tracking in cpuacct Mike Chan
2010-05-19 1:30 ` Mike Chan
2010-05-19 1:30 ` [PATCH 3/4] scheduler: cpuacct: Enable platform callbacks for cpuacct power tracking Mike Chan
2010-05-19 1:30 ` Mike Chan
[not found] ` <1274232620-23003-4-git-send-email-mike-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>
2010-05-19 9:30 ` [PATCH] scheduler: Extract cgroups_cpuaccount code from sched.c into own file Thomas Renninger
2010-05-19 9:30 ` Thomas Renninger
[not found] ` <201005191130.42851.trenn-l3A5Bk7waGM@public.gmane.org>
2010-05-19 9:37 ` Peter Zijlstra
2010-05-19 19:06 ` Mike Chan
2010-05-19 9:37 ` Peter Zijlstra
2010-05-19 10:27 ` Peter Zijlstra
2010-05-19 10:27 ` Peter Zijlstra
2010-05-19 10:27 ` Peter Zijlstra
2010-05-19 18:58 ` scheduler: cleanup sched.c and extract cgroup_cpuaccount stuff into separate file Thomas Renninger
2010-05-19 18:58 ` Thomas Renninger
2010-05-19 18:58 ` [PATCH 1/2] scheduler: Extract cgroups_cpuaccount code from sched.c into own file V2 Thomas Renninger
2010-05-19 18:58 ` Thomas Renninger
2010-05-19 18:58 ` [PATCH 2/2] scheduler: cgroups cpuaccouting: Make cpuusage atomic Thomas Renninger
2010-05-19 19:02 ` Peter Zijlstra
2010-05-19 19:13 ` Thomas Renninger
2010-05-19 19:13 ` Thomas Renninger
2010-05-19 19:31 ` Mike Chan
[not found] ` <201005192113.52535.trenn-l3A5Bk7waGM@public.gmane.org>
2010-05-19 19:31 ` Mike Chan
2010-05-20 10:53 ` Thomas Renninger
2010-05-20 10:53 ` Thomas Renninger
[not found] ` <1274295539-7798-3-git-send-email-trenn-l3A5Bk7waGM@public.gmane.org>
2010-05-19 19:02 ` Peter Zijlstra
2010-05-20 0:43 ` KAMEZAWA Hiroyuki
2010-05-20 0:43 ` KAMEZAWA Hiroyuki
2010-05-19 18:58 ` Thomas Renninger
2010-05-19 19:06 ` [PATCH] scheduler: Extract cgroups_cpuaccount code from sched.c into own file Mike Chan
2010-05-19 19:06 ` Mike Chan
2010-05-19 1:30 ` [PATCH 4/4] omap: cpu: Power tracking support for cgroup cpuacct Mike Chan
2010-05-19 1:30 ` Mike Chan
2010-05-19 13:11 ` Nishanth Menon
2010-05-19 15:34 ` Thomas Renninger [this message]
2010-05-19 18:56 ` Mike Chan
2010-05-19 19:00 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201005191734.27887.trenn@suse.de \
--to=trenn@suse.de \
--cc=balbir@in.ibm.com \
--cc=cpufreq@vger.kernel.org \
--cc=khilman@deeprootsystems.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=menage@google.com \
--cc=mike@android.com \
--cc=nm@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.