From: Johannes Weiner <hannes@cmpxchg.org>
To: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mel@csn.ul.ie>,
linux-mm@kvack.org
Subject: Re: [patch 3/5] vmscan: remove all_unreclaimable scan control
Date: Wed, 19 May 2010 23:34:46 +0200 [thread overview]
Message-ID: <20100519213446.GB2868@cmpxchg.org> (raw)
In-Reply-To: <20100513120536.215B.A69D9226@jp.fujitsu.com>
On Thu, May 13, 2010 at 12:25:36PM +0900, KOSAKI Motohiro wrote:
> > @@ -1789,7 +1787,7 @@ static unsigned long do_try_to_free_page
> > sc->nr_scanned = 0;
> > if (!priority)
> > disable_swap_token();
> > - shrink_zones(priority, zonelist, sc);
> > + ret = shrink_zones(priority, zonelist, sc);
>
> Please use more good name instead 'ret' ;)
Guess you are right, let me send a follow-up.
> otherwise looks good.
> Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
Thank you.
Hannes
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2010-05-19 21:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-30 23:05 [patch 0/5] vmscan: cut down on struct scan_control Johannes Weiner
2010-04-30 23:05 ` [patch 1/5] vmscan: fix unmapping behaviour for RECLAIM_SWAP Johannes Weiner
2010-05-13 3:02 ` KOSAKI Motohiro
2010-05-19 21:32 ` Johannes Weiner
2010-04-30 23:05 ` [patch 2/5] vmscan: remove may_unmap scan control Johannes Weiner
2010-04-30 23:05 ` [patch 3/5] vmscan: remove all_unreclaimable " Johannes Weiner
2010-05-13 3:25 ` KOSAKI Motohiro
2010-05-19 21:34 ` Johannes Weiner [this message]
2010-05-31 18:32 ` Greg Thelen
2010-06-01 3:29 ` [PATCH] vmscan: Fix do_try_to_free_pages() return value when priority==0 reclaim failure KOSAKI Motohiro
2010-06-01 6:48 ` KAMEZAWA Hiroyuki
2010-06-01 8:10 ` Balbir Singh
2010-06-02 0:33 ` KAMEZAWA Hiroyuki
2010-06-01 14:50 ` Greg Thelen
2010-06-04 14:32 ` Johannes Weiner
2010-04-30 23:05 ` [patch 4/5] vmscan: remove isolate_pages callback scan control Johannes Weiner
2010-05-13 3:29 ` KOSAKI Motohiro
2010-05-19 21:42 ` Johannes Weiner
2010-05-20 23:23 ` KOSAKI Motohiro
2010-04-30 23:05 ` [patch 5/5] vmscan: remove may_swap " Johannes Weiner
2010-05-13 3:36 ` KOSAKI Motohiro
2010-05-19 21:44 ` Johannes Weiner
2010-05-21 0:15 ` KOSAKI Motohiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100519213446.GB2868@cmpxchg.org \
--to=hannes@cmpxchg.org \
--cc=akpm@linux-foundation.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.