From: Christoph Hellwig <hch@infradead.org>
To: Shi Weihua <shiwh@cn.fujitsu.com>
Cc: chris.mason@oracle.com, "Yan, Zheng" <zheng.yan@oracle.com>,
linux-btrfs@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] btrfs: should add a permission check for setfacl
Date: Thu, 20 May 2010 04:33:40 -0400 [thread overview]
Message-ID: <20100520083340.GC11920@infradead.org> (raw)
In-Reply-To: <4BF1E458.7060500@cn.fujitsu.com>
On Tue, May 18, 2010 at 08:50:32AM +0800, Shi Weihua wrote:
> On btrfs, do the following
> ------------------
> # su user1
> # cd btrfs-part/
> # touch aaa
> # getfacl aaa
> # file: aaa
> # owner: user1
> # group: user1
> user::rw-
> group::rw-
> other::r--
> # su user2
> # cd btrfs-part/
> # setfacl -m u::rwx aaa
> # getfacl aaa
> # file: aaa
> # owner: user1
> # group: user1
> user::rwx <- successed to setfacl
> group::rw-
> other::r--
> ------------------
> but we should prohibit it that user2 changing user1's acl.
> In fact, on ext3 and other fs, a message occurs:
> setfacl: aaa: Operation not permitted
Can you add this as a new testcase to xfstests so that we can easiy
check for regressions and future filesystems implementing this
correctly?
next prev parent reply other threads:[~2010-05-20 8:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-18 0:50 [PATCH] btrfs: should add a permission check for setfacl Shi Weihua
2010-05-20 8:33 ` Christoph Hellwig [this message]
2010-05-24 6:38 ` Shi Weihua
2010-05-24 6:38 ` Shi Weihua
2010-05-27 19:19 ` Christoph Hellwig
2010-05-27 19:19 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100520083340.GC11920@infradead.org \
--to=hch@infradead.org \
--cc=chris.mason@oracle.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shiwh@cn.fujitsu.com \
--cc=zheng.yan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.