From: Andrew Morton <akpm@linux-foundation.org>
To: Andrey Vagin <avagin@openvz.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, stable@kernel.org,
Oleg Nesterov <oleg@tv-sign.ru>,
Pavel Emelyanov <xemul@openvz.org>,
Stanislaw Gruszka <sgruszka@redhat.com>
Subject: Re: [PATCH 2/3] posix_timer: fix error path in timer_create
Date: Thu, 20 May 2010 12:31:55 -0700 [thread overview]
Message-ID: <20100520123155.c4b7a1ed.akpm@linux-foundation.org> (raw)
In-Reply-To: <1274116688-4037-2-git-send-email-avagin@openvz.org>
On Mon, 17 May 2010 21:18:07 +0400
Andrey Vagin <avagin@openvz.org> wrote:
> move CLOCK_DISPATCH(which_clock, timer_create, (new_timer)) after all
> posible EFAULT erros.
>
> *_timer_create may allocate/get resources.
> (for example posix_cpu_timer_create does get_task_struct)
>
You've added a Cc:stable@kernel.org to the mail headers, but there is
no "Cc: <stable@kernel.org>" in the changelog. Please, if you think a
patch should go into -stable then add the tag to the changelog also -
this is more reliable and explicit than spraying things at a mailing
list.
You cc'ed stable@kernel.org on all three patches but IMO only [2/3]
(this patch) is needed in -stable.
And afaict, the bug which this patch fixes will allow a suitably-nasty
unprivileged application to leak an unbounded number of task-structs,
which is a box-killing local DoS. So yes, -stable wants this.
next prev parent reply other threads:[~2010-05-20 19:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-17 17:18 [PATCH 1/3] posix_timer: remove wrong comment Andrey Vagin
2010-05-17 17:18 ` [PATCH 2/3] posix_timer: fix error path in timer_create Andrey Vagin
2010-05-17 17:18 ` [PATCH 3/3] posix_timer: move copy_to_user(created_timer_id) down " Andrey Vagin
2010-05-18 6:53 ` Stanislaw Gruszka
2010-05-18 14:23 ` Oleg Nesterov
2010-05-18 6:49 ` [PATCH 2/3] posix_timer: fix error path " Stanislaw Gruszka
2010-05-20 19:31 ` Andrew Morton [this message]
2010-05-20 20:46 ` Thomas Gleixner
2010-05-18 6:49 ` [PATCH 1/3] posix_timer: remove wrong comment Stanislaw Gruszka
-- strict thread matches above, loose matches on Subject: below --
2010-05-17 13:41 Andrey Vagin
2010-05-17 13:41 ` [PATCH 2/3] posix_timer: fix error path in timer_create Andrey Vagin
2010-05-17 14:31 ` Stanislaw Gruszka
2010-05-17 14:55 ` Andrew Vagin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100520123155.c4b7a1ed.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=avagin@openvz.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
--cc=sgruszka@redhat.com \
--cc=stable@kernel.org \
--cc=tglx@linutronix.de \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.