From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from [140.186.70.92] (port=41375 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OFAr6-0000Wm-EF for qemu-devel@nongnu.org; Thu, 20 May 2010 14:52:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OFAr4-00026Q-Va for qemu-devel@nongnu.org; Thu, 20 May 2010 14:52:28 -0400 Received: from hall.aurel32.net ([88.191.82.174]:57834) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OFAr4-00026I-GU for qemu-devel@nongnu.org; Thu, 20 May 2010 14:52:26 -0400 Date: Thu, 20 May 2010 20:52:25 +0200 From: Aurelien Jarno Subject: Re: [Qemu-devel] [PATCH 04/22] tcg-i386: Tidy ext8s and ext16s operations. Message-ID: <20100520185225.GG20912@hall.aurel32.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: Sender: Aurelien Jarno List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Richard Henderson Cc: qemu-devel@nongnu.org On Tue, Apr 13, 2010 at 04:13:49PM -0700, Richard Henderson wrote: > Define OPC_MOVSBL and OPC_MOVSWL. Factor opcode emission to > separate functions. Don't restrict the input register to the > low 4 "q" registers; emit shifts instead if needed. > Given this patch is of the same type as the previous one, I have also benchmarked it, here are the results: | instr | size | +--------+--------+ before | 101258 | 344829 | after | 101258 | 344833 | This time the patch clearly doesn't bring an improvement, so I think it should also be rewritten without the constraints change. -- Aurelien Jarno GPG: 1024D/F1BCDB73 aurelien@aurel32.net http://www.aurel32.net