From: Samuel Ortiz <sameo@linux.intel.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 08/11] mfd: timberdale: Storage class should be before
Date: Thu, 20 May 2010 22:58:30 +0000 [thread overview]
Message-ID: <20100520225826.GD3130@sortiz.org> (raw)
In-Reply-To: <1274344740-9153-1-git-send-email-tklauser@distanz.ch>
Hi Tobias,
On Thu, May 20, 2010 at 10:39:00AM +0200, Tobias Klauser wrote:
> The C99 specification states in section 6.11.5:
>
> The placement of a storage-class specifier other than at the beginning
> of the declaration specifiers in a declaration is an obsolescent
> feature.
Patch applied, thanks.
Cheers,
Samuel.
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---
> drivers/mfd/timberdale.c | 20 ++++++++++----------
> 1 files changed, 10 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/mfd/timberdale.c b/drivers/mfd/timberdale.c
> index 2d4691a..ac59950 100644
> --- a/drivers/mfd/timberdale.c
> +++ b/drivers/mfd/timberdale.c
> @@ -86,7 +86,7 @@ timberdale_ocores_platform_data = {
> .num_devices = ARRAY_SIZE(timberdale_i2c_board_info)
> };
>
> -const static __devinitconst struct resource timberdale_xiic_resources[] = {
> +static const __devinitconst struct resource timberdale_xiic_resources[] = {
> {
> .start = XIICOFFSET,
> .end = XIICEND,
> @@ -99,7 +99,7 @@ const static __devinitconst struct resource timberdale_xiic_resources[] = {
> },
> };
>
> -const static __devinitconst struct resource timberdale_ocores_resources[] = {
> +static const __devinitconst struct resource timberdale_ocores_resources[] = {
> {
> .start = OCORESOFFSET,
> .end = OCORESEND,
> @@ -148,7 +148,7 @@ static __devinitdata struct xspi_platform_data timberdale_xspi_platform_data = {
> */
> };
>
> -const static __devinitconst struct resource timberdale_spi_resources[] = {
> +static const __devinitconst struct resource timberdale_spi_resources[] = {
> {
> .start = SPIOFFSET,
> .end = SPIEND,
> @@ -161,7 +161,7 @@ const static __devinitconst struct resource timberdale_spi_resources[] = {
> },
> };
>
> -const static __devinitconst struct resource timberdale_eth_resources[] = {
> +static const __devinitconst struct resource timberdale_eth_resources[] = {
> {
> .start = ETHOFFSET,
> .end = ETHEND,
> @@ -181,7 +181,7 @@ static __devinitdata struct timbgpio_platform_data
> .irq_base = 200,
> };
>
> -const static __devinitconst struct resource timberdale_gpio_resources[] = {
> +static const __devinitconst struct resource timberdale_gpio_resources[] = {
> {
> .start = GPIOOFFSET,
> .end = GPIOEND,
> @@ -194,7 +194,7 @@ const static __devinitconst struct resource timberdale_gpio_resources[] = {
> },
> };
>
> -const static __devinitconst struct resource timberdale_mlogicore_resources[] = {
> +static const __devinitconst struct resource timberdale_mlogicore_resources[] = {
> {
> .start = MLCOREOFFSET,
> .end = MLCOREEND,
> @@ -212,7 +212,7 @@ const static __devinitconst struct resource timberdale_mlogicore_resources[] = {
> },
> };
>
> -const static __devinitconst struct resource timberdale_uart_resources[] = {
> +static const __devinitconst struct resource timberdale_uart_resources[] = {
> {
> .start = UARTOFFSET,
> .end = UARTEND,
> @@ -225,7 +225,7 @@ const static __devinitconst struct resource timberdale_uart_resources[] = {
> },
> };
>
> -const static __devinitconst struct resource timberdale_uartlite_resources[] = {
> +static const __devinitconst struct resource timberdale_uartlite_resources[] = {
> {
> .start = UARTLITEOFFSET,
> .end = UARTLITEEND,
> @@ -238,7 +238,7 @@ const static __devinitconst struct resource timberdale_uartlite_resources[] = {
> },
> };
>
> -const static __devinitconst struct resource timberdale_radio_resources[] = {
> +static const __devinitconst struct resource timberdale_radio_resources[] = {
> {
> .start = RDSOFFSET,
> .end = RDSEND,
> @@ -331,7 +331,7 @@ static __devinitdata struct timb_dma_platform_data timb_dma_platform_data = {
> }
> };
>
> -const static __devinitconst struct resource timberdale_dma_resources[] = {
> +static const __devinitconst struct resource timberdale_dma_resources[] = {
> {
> .start = DMAOFFSET,
> .end = DMAEND,
> --
> 1.6.3.3
>
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2010-05-20 22:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-20 8:39 [PATCH 08/11] mfd: timberdale: Storage class should be before const qualifier Tobias Klauser
2010-05-20 22:58 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100520225826.GD3130@sortiz.org \
--to=sameo@linux.intel.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.