From: tytso@mit.edu
To: Curt Wohlgemuth <curtw@google.com>
Cc: ext4 development <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] ext4: check for a good block group before loading buddy pages
Date: Thu, 20 May 2010 23:10:23 -0400 [thread overview]
Message-ID: <20100521031023.GC11651@thunk.org> (raw)
In-Reply-To: <AANLkTikhy3LJl9vRhonzIP90tYmOsm98-B8VXPFAhPt5@mail.gmail.com>
On Fri, May 07, 2010 at 09:00:16AM -0700, Curt Wohlgemuth wrote:
> This adds a new field in ext4_group_info to cache the largest available
> block range in a block group; and don't load the buddy pages until *after*
> we've done a sanity check on the block group.
>
> With large allocation requests (e.g., fallocate(), 8MiB) and relatively full
> partitions, it's easy to have no block groups with a block extent large
> enough to satisfy the input request length. This currently causes the loop
> during cr == 0 in ext4_mb_regular_allocator() to load the buddy bitmap pages
> for EVERY block group. That can be a lot of pages. The patch below allows
> us to call ext4_mb_good_group() BEFORE we load the buddy pages.
>
>Signed-off-by: Curt Wohlgemuth <curtw@google.com>
Added to the ext4 patch queue.
- Ted
prev parent reply other threads:[~2010-05-21 3:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-07 16:00 [PATCH] ext4: check for a good block group before loading buddy pages Curt Wohlgemuth
2010-05-21 3:10 ` tytso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100521031023.GC11651@thunk.org \
--to=tytso@mit.edu \
--cc=curtw@google.com \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.