From: Jens Axboe <axboe@kernel.dk>
To: Konstantin Khlebnikov <khlebnikov@openvz.org>
Cc: linux-kernel@vger.kernel.org, Dmitry Monakhov <dmonakhov@openvz.org>
Subject: Re: [PATCH 1/2] cfq-iosched: remove dead_key from cfq_io_context
Date: Fri, 21 May 2010 11:40:47 +0200 [thread overview]
Message-ID: <20100521094047.GB11217@kernel.dk> (raw)
In-Reply-To: <20100520192134.19366.88949.stgit@zurg>
On Thu, May 20 2010, Konstantin Khlebnikov wrote:
> Remove ->dead_key field from cfq_io_context to shrink its size to 128 bytes.
> (64 bytes for 32-bit hosts)
>
> Use lower bit in ->key as dead-mark, instead of moving key to separate field.
> After this for dead cfq_io_context we got cic->key != cfqd automatically.
> Thus, io_context's last-hit cache should work without changing.
>
> Now to check ->key for non-dead state compare it with cfqd,
> instead of checking ->key for non-null value as it was before.
>
> Plus remove obsolete race protection in cfq_cic_lookup.
> This race gone after v2.6.24-1728-g4ac845a
This, and the second patch, look really good. How much testing have you
done with it?
--
Jens Axboe
next prev parent reply other threads:[~2010-05-21 9:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-20 19:21 [PATCH 1/2] cfq-iosched: remove dead_key from cfq_io_context Konstantin Khlebnikov
2010-05-20 19:21 ` [PATCH 2/2] cfq-iosched: compact io_context radix_tree Konstantin Khlebnikov
2010-05-21 9:40 ` Jens Axboe [this message]
2010-05-21 14:53 ` [PATCH 1/2] cfq-iosched: remove dead_key from cfq_io_context Konstantin Khlebnikov
2010-05-21 17:34 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100521094047.GB11217@kernel.dk \
--to=axboe@kernel.dk \
--cc=dmonakhov@openvz.org \
--cc=khlebnikov@openvz.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.