From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=34552 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OFOjD-0002q9-8X
	for qemu-devel@nongnu.org; Fri, 21 May 2010 05:41:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <aurelien@aurel32.net>) id 1OFOj6-0006cC-HU
	for qemu-devel@nongnu.org; Fri, 21 May 2010 05:41:14 -0400
Received: from hall.aurel32.net ([88.191.82.174]:58542)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <aurelien@aurel32.net>) id 1OFOj5-0006bl-UB
	for qemu-devel@nongnu.org; Fri, 21 May 2010 05:41:08 -0400
Date: Fri, 21 May 2010 11:40:54 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 16/22] tcg-i386: Tidy setcc.
Message-ID: <20100521094054.GH1950@volta.aurel32.net>
References: <cover.1272479073.git.rth@twiddle.net>
	<d7fa5c2474a9064b04be2c7dc90f764131dbc276.1272479073.git.rth@twiddle.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <d7fa5c2474a9064b04be2c7dc90f764131dbc276.1272479073.git.rth@twiddle.net>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org

On Wed, Apr 14, 2010 at 11:07:27AM -0700, Richard Henderson wrote:
> Define and use OPC_SETCC.
> 
> Signed-off-by: Richard Henderson <rth@twiddle.net>

Acked-by: Aurelien Jarno <aurelien@aurel32.net>

> ---
>  tcg/i386/tcg-target.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c
> index 27e9e9e..0c1a53a 100644
> --- a/tcg/i386/tcg-target.c
> +++ b/tcg/i386/tcg-target.c
> @@ -189,6 +189,7 @@ static inline int tcg_target_const_match(tcg_target_long val,
>  #define OPC_PUSH_Iv	(0x68)
>  #define OPC_PUSH_Ib	(0x6a)
>  #define OPC_RET		(0xc3)
> +#define OPC_SETCC	(0x90 | P_EXT)	/* ... plus condition code */
>  #define OPC_SHIFT_1	(0xd1)
>  #define OPC_SHIFT_Ib	(0xc1)
>  #define OPC_SHIFT_cl	(0xd3)
> @@ -600,8 +601,7 @@ static void tcg_out_setcond(TCGContext *s, TCGCond cond, TCGArg dest,
>                              TCGArg arg1, TCGArg arg2, int const_arg2)
>  {
>      tcg_out_cmp(s, arg1, arg2, const_arg2);
> -    /* setcc */
> -    tcg_out_modrm(s, 0x90 | tcg_cond_to_jcc[cond] | P_EXT, 0, dest);
> +    tcg_out_modrm(s, OPC_SETCC | tcg_cond_to_jcc[cond], 0, dest);
>      tcg_out_ext8u(s, dest, dest);
>  }
>  
> -- 
> 1.6.6.1
> 
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net