From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=51565 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1OFOkk-0003hS-TC
	for qemu-devel@nongnu.org; Fri, 21 May 2010 05:43:38 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <aurelien@aurel32.net>) id 1OFOk9-0006pv-JE
	for qemu-devel@nongnu.org; Fri, 21 May 2010 05:42:50 -0400
Received: from hall.aurel32.net ([88.191.82.174]:46106)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <aurelien@aurel32.net>) id 1OFOk8-0006pZ-PY
	for qemu-devel@nongnu.org; Fri, 21 May 2010 05:42:13 -0400
Date: Fri, 21 May 2010 11:41:59 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH 18/22] tcg-i386: Tidy multiply.
Message-ID: <20100521094159.GJ1950@volta.aurel32.net>
References: <cover.1272479073.git.rth@twiddle.net>
	<e5081b0bdc3e2d165f24b23ef61def3cc03282dc.1272479073.git.rth@twiddle.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
In-Reply-To: <e5081b0bdc3e2d165f24b23ef61def3cc03282dc.1272479073.git.rth@twiddle.net>
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>
Cc: qemu-devel@nongnu.org

On Wed, Apr 14, 2010 at 11:29:31AM -0700, Richard Henderson wrote:
> Define and use OPC_IMUL_GvEv{,Ib,Iz}.
> 
> Signed-off-by: Richard Henderson <rth@twiddle.net>

Acked-by: Aurelien Jarno <aurelien@aurel32.net>

> ---
>  tcg/i386/tcg-target.c |    9 ++++++---
>  1 files changed, 6 insertions(+), 3 deletions(-)
> 
> diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c
> index c3f3e4d..020faf0 100644
> --- a/tcg/i386/tcg-target.c
> +++ b/tcg/i386/tcg-target.c
> @@ -184,6 +184,9 @@ static inline int tcg_target_const_match(tcg_target_long val,
>  #define OPC_MOVZWL	(0xb7 | P_EXT)
>  #define OPC_MOVSBL	(0xbe | P_EXT)
>  #define OPC_MOVSWL	(0xbf | P_EXT)
> +#define OPC_IMUL_GvEv	(0xaf | P_EXT)
> +#define OPC_IMUL_GvEvIb	(0x6b)
> +#define OPC_IMUL_GvEvIz	(0x69)
>  #define OPC_POP_r32	(0x58)
>  #define OPC_PUSH_r32	(0x50)
>  #define OPC_PUSH_Iv	(0x68)
> @@ -1178,14 +1181,14 @@ static inline void tcg_out_op(TCGContext *s, TCGOpcode opc,
>              int32_t val;
>              val = args[2];
>              if (val == (int8_t)val) {
> -                tcg_out_modrm(s, 0x6b, args[0], args[0]);
> +                tcg_out_modrm(s, OPC_IMUL_GvEvIb, args[0], args[0]);
>                  tcg_out8(s, val);
>              } else {
> -                tcg_out_modrm(s, 0x69, args[0], args[0]);
> +                tcg_out_modrm(s, OPC_IMUL_GvEvIz, args[0], args[0]);
>                  tcg_out32(s, val);
>              }
>          } else {
> -            tcg_out_modrm(s, 0xaf | P_EXT, args[0], args[2]);
> +            tcg_out_modrm(s, OPC_IMUL_GvEv, args[0], args[2]);
>          }
>          break;
>      case INDEX_op_mulu2_i32:
> -- 
> 1.6.6.1
> 
> 
> 
> 

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net