From: Florian Mickler <florian@mickler.org>
To: Joe Perches <joe@perches.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Stephen Hemminger <shemminger@vyatta.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] get_maintainer.pl: improve config-file support
Date: Fri, 21 May 2010 23:08:23 +0200 [thread overview]
Message-ID: <20100521230823.7f0a0200@schatten.dmk.lab> (raw)
In-Reply-To: <1274473288.8140.569.camel@Joe-Laptop.home>
On Fri, 21 May 2010 13:21:28 -0700
Joe Perches <joe@perches.com> wrote:
> On Fri, 2010-05-21 at 13:13 -0700, Andrew Morton wrote:
> > On Thu, 20 May 2010 08:46:15 +0200
> > Florian Mickler <florian@mickler.org> wrote:
> > > What's the status of this patch?
> > > Do you take it, or do you have an issue with it? This is a clear
> > > improvement in my opinion.
> > Joe didn't sound very excited about it.
> > If we're going to do this, we should hurry up, please - it'd be silly
> > to introduce a config file and then change its format shortly
> > afterwards.
>
> If an ".ini" style config is used, I think it'd be better to
> put this stuff in .git/config under a proper section so that
> any checking style script (checkpatch, smatch, smpl, etc)
> has a standard place to put stuff.
>
> I think what I posted requires less overall work and doesn't
> need updating every time a new option is added, but overall
> the capability isn't all that necessary.
Feature-like it is the same. But in my opinion my solution with a
key=value approach (why .ini? where did you get that from?) is more
obvious.
I've never seen this hacky thing where you put "--option" tokens in
a file in my life.
Of course, Joe's solution is short and to the point.
But i would consider it more "quick'n'dirty" than elegant.
As for the placement:
This has nothing to do with git, aside from using it as a _possible_
way to determine the maintainers. So I doubt that we should
mess with .git/config. If you want to go that road of a more general
solution, a common /scripts/ config-file would be more realistic.
Cheers,
Flo
prev parent reply other threads:[~2010-05-21 21:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-12 21:12 [PATCH] get_maintainer.pl: improve config-file support florian
2010-05-12 22:28 ` Joe Perches
2010-05-13 7:56 ` Florian Mickler
2010-05-20 6:46 ` Florian Mickler
2010-05-21 20:13 ` Andrew Morton
2010-05-21 20:21 ` Joe Perches
2010-05-21 21:08 ` Florian Mickler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100521230823.7f0a0200@schatten.dmk.lab \
--to=florian@mickler.org \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=shemminger@vyatta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.