From: Paul Mundt <lethal@linux-sh.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: "linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
linux-serial@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH] sh: fix Oops in the serial SCI driver
Date: Sat, 22 May 2010 08:10:56 +0000 [thread overview]
Message-ID: <20100522081056.GE17814@linux-sh.org> (raw)
In-Reply-To: <Pine.LNX.4.64.1005211728520.8450@axis700.grange> <Pine.LNX.4.64.1005211722410.8450@axis700.grange> <Pine.LNX.4.64.1005211721030.8450@axis700.grange>
On Fri, May 21, 2010 at 05:22:40PM +0200, Guennadi Liakhovetski wrote:
> Fix an Oops, triggering, if the DMA buffer allocation for the Rx channel in
> sh-sci.c fails.
On Fri, May 21, 2010 at 05:28:51PM +0200, Guennadi Liakhovetski wrote:
> This prevents the driver from unloading, while it is in use. Unloading of the
> driver, while its DMA channels are held, leads to a kernel Oops.
On Fri, May 21, 2010 at 05:30:12PM +0200, Guennadi Liakhovetski wrote:
> If all descriptors on a channel are terminated or the channel is released,
> update the completed cookie counter to match the last cookie. This prevents
> inconsistency warning on resumed DMA operation.
Applied, thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Paul Mundt <lethal@linux-sh.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: "linux-sh@vger.kernel.org" <linux-sh@vger.kernel.org>,
linux-serial@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>
Subject: Re: [PATCH] sh: fix Oops in the serial SCI driver
Date: Sat, 22 May 2010 17:10:56 +0900 [thread overview]
Message-ID: <20100522081056.GE17814@linux-sh.org> (raw)
In-Reply-To: <Pine.LNX.4.64.1005211728520.8450@axis700.grange> <Pine.LNX.4.64.1005211722410.8450@axis700.grange> <Pine.LNX.4.64.1005211721030.8450@axis700.grange>
On Fri, May 21, 2010 at 05:22:40PM +0200, Guennadi Liakhovetski wrote:
> Fix an Oops, triggering, if the DMA buffer allocation for the Rx channel in
> sh-sci.c fails.
On Fri, May 21, 2010 at 05:28:51PM +0200, Guennadi Liakhovetski wrote:
> This prevents the driver from unloading, while it is in use. Unloading of the
> driver, while its DMA channels are held, leads to a kernel Oops.
On Fri, May 21, 2010 at 05:30:12PM +0200, Guennadi Liakhovetski wrote:
> If all descriptors on a channel are terminated or the channel is released,
> update the completed cookie counter to match the last cookie. This prevents
> inconsistency warning on resumed DMA operation.
Applied, thanks.
next prev parent reply other threads:[~2010-05-22 8:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-21 15:30 [PATCH] sh: guard cookie consistency across termination in the DMA Guennadi Liakhovetski
2010-05-21 15:28 ` [PATCH] sh: prevent the DMA driver from unloading, while in use Guennadi Liakhovetski
2010-05-21 15:22 ` [PATCH] sh: fix Oops in the serial SCI driver Guennadi Liakhovetski
2010-05-21 15:22 ` Guennadi Liakhovetski
2010-05-22 8:10 ` Paul Mundt [this message]
2010-05-22 8:10 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100522081056.GE17814@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=dan.j.williams@intel.com \
--cc=g.liakhovetski@gmx.de \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.