From: Al Viro <viro@ZenIV.linux.org.uk>
To: Prarit Bhargava <prarit@redhat.com>
Cc: linux-kernel@vger.kernel.org, stable@kernel.org,
phillip@lougher.demon.co.uk, alain@knaff.lu, hpa@zytor.com
Subject: Re: [PATCH]: bunzip2: Fix warning in get_next_block()
Date: Sat, 22 May 2010 15:07:41 +0100 [thread overview]
Message-ID: <20100522140741.GM31073@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20100522135933.28675.17356.sendpatchset@prarit.bos.redhat.com>
On Sat, May 22, 2010 at 10:04:07AM -0400, Prarit Bhargava wrote:
> Fix checkstack compile warning in get_next_block():
>
> lib/decompress_bunzip2.c: In function `get_next_block':
> lib/decompress_bunzip2.c:511: warning: the frame size of 1920 bytes is larger than 1024 bytes
> int dbufCount, nextSym, dbufSize, groupCount, selector,
> - i, j, k, t, runPos, symCount, symTotal, nSelectors,
> - byteCount[256];
> - unsigned char uc, symToByte[256], mtfSymbol[256], *selectors;
> + i, j, k, t, runPos, symCount, symTotal, nSelectors;
> + static int byteCount[256];
> + unsigned char uc, *selectors;
> + static unsigned char symToByte[256], mtfSymbol[256];
> unsigned int *dbuf, origPtr;
Um... Some details might be useful, starting with "why can't that function
be called from several processes at once"...
next prev parent reply other threads:[~2010-05-22 14:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-22 14:04 [PATCH]: bunzip2: Fix warning in get_next_block() Prarit Bhargava
2010-05-22 14:07 ` Al Viro [this message]
2010-05-22 18:07 ` Prarit Bhargava
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100522140741.GM31073@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=alain@knaff.lu \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=phillip@lougher.demon.co.uk \
--cc=prarit@redhat.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.